Page MenuHomePhabricator

Separating comments from actions in the wrong order
Closed, ResolvedPublic

Description

In days of yore, if I updated a diff or resigned, it would say, in ONE box, my comment, and also the action. Now the comment comes after the action!

That's all well and good, except in the case of resigning...if I resign from a diff, the resignation needs to come after the comment, or "I commented on the diff," which resubscribes me so I still get emails. That's the bug. Choosing "resign" doesn't work if a comment is added.

Event Timeline

akramer raised the priority of this task from to Needs Triage.
akramer updated the task description. (Show Details)
akramer added a subscriber: akramer.

I can't immediately reproduce this at HEAD, so I think this might be fixed and Facebook is just a bit behind. Are you seeing a UI and interaction similar to this one, or different?

(At HEAD, the "removed a reviewer" action is a side effect of resigning: I performed this set of actions by selecting "resign" and typing text, only.)

Screen_Shot_2014-04-26_at_12.57.10_PM.png (127×410 px, 15 KB)

chad claimed this task.

We had a short period of time where stuff wasn't grouped. I assume you'll catch up soon from what I've heard. If there is still an issue, let us know.