Page MenuHomePhabricator

Existing Differential revision from bare diff throws Unhandled RuntimeException (Undefined variable: commits_for_links) after upgrading
Closed, ResolvedPublic

Description

After upgrading to phabricator 524e8a, trying to open a specific, existing Differential revision I get an error

Unhandled Exception ("RuntimeException")

Undefined variable: commits_for_links

That particular differential revision was created without repository-linking, from a bare diff. The revision has comments and was in the state planned changes.

The diff that it was created with was a combination of three diffs generated with git diff. One file path had two diff sections, which the previous version of phabricator we were using was fine with. The previous version must have been c40420.

Event Timeline

ite-klass raised the priority of this task from to Needs Triage.
ite-klass updated the task description. (Show Details)
ite-klass added a project: Differential.
ite-klass added a subscriber: ite-klass.
epriestley claimed this task.

This should be fixed in HEAD (rPac0ad2) if you update.

(I'm going to close this issue since I'm pretty sure the patch fixes it, but yell if that's not the case.)

Thanks for the report!