Page MenuHomePhabricator

Validate, tweak timeline on mobile
Closed, ResolvedPublic

Description

I didn't thoroughly test mobile, will likely need a few classes.

Revisions and Commits

Event Timeline

chad claimed this task.
chad raised the priority of this task from to High.
chad updated the task description. (Show Details)
chad added a project: Design.
chad added subscribers: chad, epriestley.

This is a little bit weird too -- the links are grey for "subscribers" (since they're users?) but blue for other object types.

Screen_Shot_2014-02-12_at_12.12.37_PM.png (65×301 px, 8 KB)

Probably tricky to fix without annotating all the links with "this is an actor handle link" across every app though.

this was intentional, we already bold things that are clickable, and I wanted a little less intention on the actor and a little more on the object, at least to differentiate them. I'll keep an eye on it though in case it's not working. (I do at some point, was a better "link blue" color).

Oh -- specifically, when a user is an object (as on the right side of "added subscribers", they don't get the "more attention" color.

I think this will look weird in Differential soon, e.g:

epriestley (dark blue) added reviewers: chad (dark blue), #qa (light blue)

Yeah, still intentional. I'm leaning towards people displaying one way and objects displaying another. When it's both, I went with person staying consistent instead of object staying consistent. Is this a little weird to you or a lot weird? Can revisit at end of week?

Ah, okay. Just a teeny tiny bit weird, I'd be fine with never changing it unless the mixed-lists end up looking crazily weird.

(I just got back home, so I wanted to have some time today on secure to see how it shakes out - I landed it and left, haha)

I've been very happy with it so far. I have it almost-working in my sandbox for Differential, too.

Should moving tasks to a new board generate a transaction? I moved this to Design (In Progress)

I think they should, but that those transactions shouldn't send email. Seem reasonable?

I'm leaning towards making them all dark, bold in timeline, blue everywhere else after using it for a day. Basically links would be one shade darker than the surrounding text and bold. I can send you a diff to feel out.