Page MenuHomePhabricator
Create Task
Maniphest T4389

Auto abandon open diffs whose changes were landed in another diff
Closed, WontfixPublic
Actions

Description

I've run into an odd behavior when basing two diffs off the same branch. When you land them, choosing the preferred commit message, it leaves the other diff open.

Event Timeline

• nosideeffects created this task.Feb 7 2014, 4:11 PM
• nosideeffects raised the priority of this task from to Needs Triage.
• nosideeffects updated the task description. (Show Details)
• nosideeffects added a subscriber: • nosideeffects.
btrahan added projects: Arcanist, Differential.May 23 2014, 5:49 PM
btrahan added a subscriber: btrahan.
epriestley closed this task as Wontfix.May 24 2014, 1:10 PM
epriestley claimed this task.

I'm not sure how to reproduce this.

It's expected that if you combine the changes from several diffs into a single commit, we can't detect when they were landed. Detection is based on commit hashes, tree hashes (in Git) and "Differential Revision: ..." text in the commit message.

It sounds like you might be expecting detection to be based on diff content instead. This isn't practical, since many diffs may have the same content, and diffs that land often have different content than diffs that were reviewed (because of rebases).

I'm closing this as "Wontfix" because there isn't enough information for us to figure out how to address this.

Phabricator · Built by Phacility