Page MenuHomePhabricator
Create Task
Maniphest T4262

Come up with a distinctive term for "object name" and provide it on all named objects
Closed, ResolvedPublic
Actions

Description

We have a fair amount of code which manually builds strings like D123 like this:

$object_name = "D".$revision->getID();

It would be nice to centralize this into the objets, so we just call:

$revision->getObjectName();

However, "object name" is pretty much the vaguest possible name for this. I've primarily avoided building this because getObjectName() is such an ambiguous, garbage method name.

It would be nice to come up with some better name to identify the D123, T123, rX sort of strings we use as local/human object identifiers.

Revisions and Commits

rP Phabricator
D7882rPee2680794f75 Recognize "#project" as a formal object name

Event Timeline

epriestley created this task.Dec 24 2013, 6:31 PM
epriestley raised the priority of this task from to Wishlist.
epriestley updated the task description. (Show Details)
epriestley added a project: Phabricator.
epriestley added subscribers: epriestley, chad, btrahan.

"Designation", "Monogram" and "Trade Name" seem like the least-bad thesaurus candidates.

epriestley added a comment.Dec 24 2013, 6:35 PM

I think "monogram" isn't bad -- it's a reasonably good fit, and we're very unlikely to use it for anything else.

asherkin added a subscriber: asherkin.Dec 24 2013, 9:27 PM

+1 for Monogram, although Wikipedia adds Cypher to the suggestions - I think Monogram is slightly more obvious though.

epriestley added a comment.Jan 3 2014, 1:35 AM

Did anyone have objections to "monogram"? After mulling this over for a couple of days I still feel like it's the leading contender.

epriestley edited this Maniphest Task.Jan 3 2014, 5:21 PM
epriestley edited this Maniphest Task.Jan 3 2014, 8:24 PM
btrahan added a comment.Jan 7 2014, 12:29 AM

(I dig monogram. I even approved some new code using it!)

epriestley closed this task as Resolved.Jan 7 2014, 12:31 AM
epriestley claimed this task.

Cool. I'm just going to close this since there's a huge hard-to-grep-for long tail and I don't think this is important enough to make a big push over, but we can start doing this in new/updated code as stuff arises. I think it'll be a small consistency win in the long run.

Herald added a subscriber: eadler. · View Herald TranscriptSep 15 2017, 5:25 PM
Phabricator · Built by Phacility