Page MenuHomePhabricator

Exception when viewing branch in Diffusion
Closed, ResolvedPublic

Description

This exception occurs when viewing a branch in Diffusion:

Expected "<mode> <type> <hash> <size> <name>", for ls-tree of "uat:", got: 100644 blob 8a1f5194454879ef48ff6a0c900a9d584290644f 7535961	fxcop-baseline.xml

Revisions and Commits

Event Timeline

waynea assigned this task to epriestley.
waynea raised the priority of this task from to Needs Triage.
waynea updated the task description. (Show Details)
waynea added a project: Diffusion.
waynea added subscribers: waynea, hach-que.

Checked the string, it expects 4 spaces, but the character between the size and the file name is actually a table. This is the string URL encoded:

100644+blob+040d4124dbbf75d8ddb930aa81023a4004d2b9ac+7589804%09fxcop-baseline.xml

Placing this before the if check (line 103 of ConduitAPI_diffusion_browsequery_Method.php) fixes the issue:

$line = str_replace("\t", " ", $line);

Thanks! This should be fixed in HEAD.