Page MenuHomePhabricator

How to heal obsolete configuration option 'differential.anonymous-access'
Closed, ResolvedPublic

Description

After updating to HEAD I received the setup issue Obsolete Configuration Option "differential.anonymous-access".
I was unable to fix that and tried the following:

  1. add 'differential.anonymous-access' => false, to my custom/myconfig.conf.php
  2. remove 'differential.anonymous-access' => false, from conf/default.conf.php
  3. looking for differential.anonymous-access on the phabricator / config / differential site without success.

So I am confused how to make phabricator happy unless to just ignore the issue.
Best regards
ralf

Event Timeline

rall0r raised the priority of this task from to Needs Triage.
rall0r updated the task description. (Show Details)
rall0r added a project: Phabricator.
rall0r added a subscriber: rall0r.

Remove all instances of 'differential.anonymous-access'. You can also ignore the issue safely.

(The "Ignore" button on the issue list will stop it from complaining.)

I am just curious: I have not found any instances of 'differential.anonymous-access'.
So I guess I just looked at the wrong places.
I grepped a little, just found something in conf/default.conf.php.

So may I have to look at the database instead?

Of course I can just ignore the issue :-)

The error message is supposed to tell you where to look. What's the exact text the issue is showing you?

It says

The configuration option 'differential.anonymous-access' has been removed. You may delete it at your convenience.

Phabricator now has meaningful global access controls. See `policy.allow-public`.

This configuration value is defined in this configuration source: File 'custom/myconfig'.

But: the myconfig.conf.php just looks like this

  // This will be the base domain for your install, and must be configured.
  // Use "https://" if you have SSL. See below for some notes.
  'phabricator.base-uri' => 'http://phabricator.example.org/',

  // Connection information for MySQL.
  'mysql.host' => 'localhost',
  'mysql.user' => 'myUser',
  'mysql.pass' => 'mySecretPassword',

  // Basic email domain configuration.
  'metamta.default-address' => 'bla@example.org',
  'metamta.domain'          => 'www.example.org',

  'storage.local-disk.path' => '/storage/disk1/www/htdocs/p/files/'

  // NOTE: Check default.conf.php for detailed explanations of all the
  // configuration options, including these.

) + phabricator_read_config_file('production');

Try changing this line:

) + phabricator_read_config_file('production');

...to this:

);

...then restart your webserver? This assumes you haven't edited default.conf.php.

just for the record:

grep -r differential.anonymous-access *
conf/default.conf.php:  'differential.anonymous-access' => false,
src/applications/conduit/method/differential/ConduitAPI_differential_getdiff_Method.php:    return !PhabricatorEnv::getEnvConfig('differential.anonymous-access');
src/applications/config/check/PhabricatorSetupCheckExtraConfig.php:      'differential.anonymous-access' => pht(
rall0r claimed this task.

Removing + phabricator_read_config_file('production'); and restarting the webserver resolved the issue.
Thanks!

Awesome. Let us know if you run into anything else.

Oh, this was actually a bug with Phabricator, too -- cleaned up in the attached commit. The change you made is fine to keep, though.