Page MenuHomePhabricator
Create Task
Maniphest T3807

Validate regular expressions in `differential.generated-paths`
Closed, ResolvedPublic
Actions

Description

Some general issues here:

  • We don't validate regexps in differential.generated-paths, or other config which takes regexps. We can and should.
  • For config of type list<string>, we provide a simplified editor ("one value per line") but it's fairly easy to confuse this with the JSON editor used for map<string, x> since they look the same and function very similarly.
  • The examples for differential.generated-paths show JSON, which is not correct for the web editor.

Possibly we should remove the specialized list<string> editor and just make you enter JSON.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

epriestley triaged this task as Normal priority.Sep 6 2013, 3:59 PM
epriestley added a project: Setup.
epriestley added subscribers: epriestley, staticshock.
epriestley added a subscriber: hlau.Sep 12 2013, 7:49 PM

◀ Merged tasks: T3822.

epriestley added a comment.Sep 12 2013, 7:50 PM

T3822 is similar, but specifically hits the issue that getStrList() considers commas to be a token delimiter, which prevents them from being used in regexps. We should not treat them as delimiters in config of this type, and maybe not in any list<...> config.

epriestley claimed this task.Sep 12 2013, 11:53 PM
epriestley edited this Maniphest Task.Sep 13 2013, 12:19 AM
epriestley edited this Maniphest Task.Sep 13 2013, 6:48 PM
epriestley added a comment.Sep 13 2013, 6:48 PM

Closed by commit rP7a39ac43b48c.

epriestley closed this task as Resolved.Sep 13 2013, 6:48 PM
hlau added a comment.Sep 16 2013, 9:17 PM

Thanks for the fix. For the records, the following works

/([Ff]ix|[Cc]omment):(\s*,*\s*\d+)+/
/(\d+)/

for

Fix: 123, 234
comment: 123 234

chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 19 2015, 4:16 AM
Herald added a subscriber: eadler. · View Herald TranscriptSep 15 2017, 5:26 PM
Phabricator · Built by Phacility