Page MenuHomePhabricator

Problems commiting files uploaded for revision using different methods: with arcanist and creating a new raw diff
Open, Needs TriagePublic

Description

Steps to reproduce:

  • Submit files for review using arc diff --preview
  • Create revision
  • Submit other file to the same revision using create raw diff and upload file manually
  • Reviewer reject and request changes
  • Make changes.
  • Reviewer accept revision
  • Close revision and commit with arc commit --revision %revision%
    • Here it says only last file added for revision is for commit, while first files are not recognized of being part of the revision.

I could manage to solve this, creating another diff with arc diff --preview and as the revision is accepted I could commit as usual.

I think there is something weird in this behaviour. Please if you can check this, I will appreciate that.

Using latest versions versions:

phabricator 9da15fd7ab7071e3b7361463229abd4e918d9d94 (Sun, Jul 10)
arcanist f1c45a3323ae20eefe29c0a22c7923fe8b151bbf (Fri, Jul 1)
phutil 5fd2cf9d5ddd38424a54a8fba02398d527639970 (Sat, Jul 9)

Regards,

Event Timeline

chad renamed this task from [Differential] Problems commiting files uploaded for revision using different methods: with arcanist and creating a new raw diff to roblems commiting files uploaded for revision using different methods: with arcanist and creating a new raw diff.Jul 27 2016, 10:03 PM
chad renamed this task from roblems commiting files uploaded for revision using different methods: with arcanist and creating a new raw diff to Problems commiting files uploaded for revision using different methods: with arcanist and creating a new raw diff.
cxzzero added a subscriber: cxzzero.Sep 7 2016, 1:29 PM