Page MenuHomePhabricator

When a later build step fails, artifacts are released causing "Lease Working Copy" steps to throw exceptions
Open, Needs TriagePublic

Description

Okay, I swear that I've reported this before, but again, Application Search returns nothing when searching for "lease failed" or "lease working copy failed" with tasks authored by me. Apologies if I'm reporting the same bug twice.

Replication Steps

  1. Configure a build plan with a "Lease Working Copy" step, a "Sleep" step (with seconds >0) and a "Throw Exception " step which depends on "Sleep".
  2. Run the build

Expected Result

The "Lease Working Copy" step shouldn't show an exception message, and preferrably shouldn't be in the failed status. On build plans where you have multiple Lease Working Copy steps and they happen first, it makes it look like the lease failed to execute and is to blame for the build failure. I'd prefer if it showed a "Cancelled" status and, even better, showed an explaination as to why it moved into this status, i.e. "Another build step failed, so this operation was cancelled".

Actual Result

The "Lease Working Copy" throws an exception (which is logged as permanant Drydock exception) and is set to the failure status.

Event Timeline

hach-que renamed this task from When a later build step fails, artifacts are released early causing "Lease Working Copy" steps to throw exceptions to When a later build step fails, artifacts are released causing "Lease Working Copy" steps to throw exceptions.Jan 7 2016, 9:33 PM
hach-que created this task.
eadler added a project: Restricted Project.Aug 5 2016, 4:45 PM