Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F89481
D7757.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D7757.diff
View Options
diff --git a/src/applications/herald/adapter/HeraldAdapter.php b/src/applications/herald/adapter/HeraldAdapter.php
--- a/src/applications/herald/adapter/HeraldAdapter.php
+++ b/src/applications/herald/adapter/HeraldAdapter.php
@@ -199,21 +199,31 @@
);
case self::FIELD_AUTHOR:
case self::FIELD_COMMITTER:
- case self::FIELD_REPOSITORY:
case self::FIELD_REVIEWER:
return array(
self::CONDITION_IS_ANY,
self::CONDITION_IS_NOT_ANY,
);
+ case self::FIELD_REPOSITORY:
+ return array(
+ self::CONDITION_IS_ANY,
+ self::CONDITION_IS_NOT_ANY,
+ self::CONDITION_EXISTS,
+ self::CONDITION_NOT_EXISTS,
+ );
case self::FIELD_TAGS:
case self::FIELD_REVIEWERS:
case self::FIELD_CC:
case self::FIELD_AUTHOR_PROJECTS:
case self::FIELD_PROJECTS:
+ case self::FIELD_AFFECTED_PACKAGE:
+ case self::FIELD_AFFECTED_PACKAGE_OWNER:
return array(
self::CONDITION_INCLUDE_ALL,
self::CONDITION_INCLUDE_ANY,
self::CONDITION_INCLUDE_NONE,
+ self::CONDITION_EXISTS,
+ self::CONDITION_NOT_EXISTS,
);
case self::FIELD_DIFF_FILE:
return array(
@@ -233,12 +243,6 @@
self::CONDITION_RULE,
self::CONDITION_NOT_RULE,
);
- case self::FIELD_AFFECTED_PACKAGE:
- case self::FIELD_AFFECTED_PACKAGE_OWNER:
- return array(
- self::CONDITION_INCLUDE_ANY,
- self::CONDITION_INCLUDE_NONE,
- );
case self::FIELD_CONTENT_SOURCE:
return array(
self::CONDITION_IS,
diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php
--- a/src/applications/herald/storage/HeraldRule.php
+++ b/src/applications/herald/storage/HeraldRule.php
@@ -16,7 +16,7 @@
protected $ruleType;
protected $isDisabled = 0;
- protected $configVersion = 14;
+ protected $configVersion = 15;
private $ruleApplied = self::ATTACHABLE; // phids for which this rule has been applied
private $validAuthor = self::ATTACHABLE;
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/uz/ys/5aezmvohbozkzwzp
Default Alt Text
D7757.diff (2 KB)
Attached To
Mode
D7757: Allow Herald rules to check for revisions with no reviewers
Attached
Detach File
Event Timeline
Log In to Comment