Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F88442
D7733.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D7733.diff
View Options
diff --git a/src/applications/phragment/storage/PhragmentFragment.php b/src/applications/phragment/storage/PhragmentFragment.php
--- a/src/applications/phragment/storage/PhragmentFragment.php
+++ b/src/applications/phragment/storage/PhragmentFragment.php
@@ -162,6 +162,33 @@
$mappings[$path] = $data;
}
+ // We need to detect any directories that are in the ZIP folder that
+ // aren't explicitly noted in the ZIP. This can happen if the file
+ // entries in the ZIP look like:
+ //
+ // * something/blah.png
+ // * something/other.png
+ // * test.png
+ //
+ // Where there is no explicit "something/" entry.
+ foreach ($mappings as $path_key => $data) {
+ if ($data === null) {
+ continue;
+ }
+ $directory = dirname($path_key);
+ while ($directory !== ".") {
+ if (!array_key_exists($directory, $mappings)) {
+ $mappings[$directory] = null;
+ }
+ if (dirname($directory) === $directory) {
+ // dirname() will not reduce this directory any further; to
+ // prevent infinite loop we just break out here.
+ break;
+ }
+ $directory = dirname($directory);
+ }
+ }
+
// Adjust the paths relative to this fragment so we can look existing
// fragments up in the DB.
$base_path = $this->getPath();
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/ko/m2/pkuyr6sdofw32kyn
Default Alt Text
D7733.diff (1 KB)
Attached To
Mode
D7733: Implicitly detect directories when updating a fragment from a ZIP
Attached
Detach File
Event Timeline
Log In to Comment