Page MenuHomePhabricator
Files F88079

D7716.diff
All Users
Actions

D7716.diff
View Options

diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
@@ -382,10 +382,15 @@
if (!$user->isLoggedIn()) {
// TODO: Eventually, everything should run through this. For now, we're
// only using it to get a consistent "Login to Comment" button.
- $comment_form = id(new PhabricatorApplicationTransactionCommentView())
+ $comment_box = id(new PhabricatorApplicationTransactionCommentView())
->setUser($user)
->setRequestURI($request->getRequestURI());
$preview_panel = null;
+ } else {
+ $comment_box = id(new PHUIObjectBoxView())
+ ->setFlush(true)
+ ->setHeaderText($comment_header)
+ ->appendChild($comment_form);
}
$object_box = id(new PHUIObjectBoxView())
@@ -396,11 +401,6 @@
$object_box->addPropertyList($description);
}
- $comment_box = id(new PHUIObjectBoxView())
- ->setFlush(true)
- ->setHeaderText($comment_header)
- ->appendChild($comment_form);
-
return $this->buildApplicationPage(
array(
$crumbs,
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
@@ -85,6 +85,7 @@
$uri = id(new PhutilURI('/login/'))
->setQueryParam('next', (string) $this->getRequestURI());
return id(new PHUIObjectBoxView())
+ ->setFlush(true)
->setHeaderText(pht('Add Comment'))
->appendChild(
javelin_tag(

File Metadata

Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/6y/2e/i3vejovjfmbd6hti
Default Alt Text
D7716.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility