Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F86610
D7648.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D7648.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -621,6 +621,7 @@
'DoorkeeperRemarkupRule' => 'applications/doorkeeper/remarkup/DoorkeeperRemarkupRule.php',
'DoorkeeperRemarkupRuleAsana' => 'applications/doorkeeper/remarkup/DoorkeeperRemarkupRuleAsana.php',
'DoorkeeperRemarkupRuleJIRA' => 'applications/doorkeeper/remarkup/DoorkeeperRemarkupRuleJIRA.php',
+ 'DoorkeeperTagView' => 'applications/doorkeeper/view/DoorkeeperTagView.php',
'DoorkeeperTagsController' => 'applications/doorkeeper/controller/DoorkeeperTagsController.php',
'DrydockAllocatorWorker' => 'applications/drydock/worker/DrydockAllocatorWorker.php',
'DrydockApacheWebrootInterface' => 'applications/drydock/interface/webroot/DrydockApacheWebrootInterface.php',
@@ -2944,6 +2945,7 @@
'DoorkeeperRemarkupRule' => 'PhutilRemarkupRule',
'DoorkeeperRemarkupRuleAsana' => 'DoorkeeperRemarkupRule',
'DoorkeeperRemarkupRuleJIRA' => 'DoorkeeperRemarkupRule',
+ 'DoorkeeperTagView' => 'AphrontView',
'DoorkeeperTagsController' => 'PhabricatorController',
'DrydockAllocatorWorker' => 'PhabricatorWorker',
'DrydockApacheWebrootInterface' => 'DrydockWebrootInterface',
diff --git a/src/applications/differential/field/specification/DifferentialJIRAIssuesFieldSpecification.php b/src/applications/differential/field/specification/DifferentialJIRAIssuesFieldSpecification.php
--- a/src/applications/differential/field/specification/DifferentialJIRAIssuesFieldSpecification.php
+++ b/src/applications/differential/field/specification/DifferentialJIRAIssuesFieldSpecification.php
@@ -58,16 +58,11 @@
$links = array();
foreach ($xobjs as $xobj) {
- $links[] = phutil_tag(
- 'a',
- array(
- 'href' => $xobj->getObjectURI(),
- 'target' => '_blank',
- ),
- $xobj->getObjectID());
+ $links[] = id(new DoorkeeperTagView())
+ ->setExternalObject($xobj);
}
- return phutil_implode_html(', ', $links);
+ return phutil_implode_html(phutil_tag('br'), $links);
}
public function shouldAppearOnConduitView() {
diff --git a/src/applications/doorkeeper/view/DoorkeeperTagView.php b/src/applications/doorkeeper/view/DoorkeeperTagView.php
new file mode 100644
--- /dev/null
+++ b/src/applications/doorkeeper/view/DoorkeeperTagView.php
@@ -0,0 +1,42 @@
+<?php
+
+final class DoorkeeperTagView extends AphrontView {
+
+ private $xobj;
+
+ public function setExternalObject(DoorkeeperExternalObject $xobj) {
+ $this->xobj = $xobj;
+ return $this;
+ }
+
+ public function render() {
+ $xobj = $this->xobj;
+ if (!$xobj) {
+ throw new Exception('Call setExternalObject() before render()!');
+ }
+
+ $tag_id = celerity_generate_unique_node_id();
+
+ $href = $xobj->getObjectURI();
+
+ $spec = array(
+ 'id' => $tag_id,
+ 'ref' => array(
+ $xobj->getApplicationType(),
+ $xobj->getApplicationDomain(),
+ $xobj->getObjectType(),
+ $xobj->getObjectID(),
+ ),
+ );
+
+ Javelin::initBehavior('doorkeeper-tag', array('tags' => array($spec)));
+
+ return id(new PhabricatorTagView())
+ ->setID($tag_id)
+ ->setHref($href)
+ ->setName($href)
+ ->setType(PhabricatorTagView::TYPE_OBJECT)
+ ->setExternal(true);
+ }
+
+}
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/pd/jh/2tx653mqr32ahnew
Default Alt Text
D7648.diff (3 KB)
Attached To
Mode
D7648: Render linked JIRA issues with a Doorkeeper tag
Attached
Detach File
Event Timeline
Log In to Comment