Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F86146
D7662.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
965 B
Referenced Files
None
Subscribers
None
D7662.diff
View Options
diff --git a/src/parser/xhpast/api/XHPASTNode.php b/src/parser/xhpast/api/XHPASTNode.php
--- a/src/parser/xhpast/api/XHPASTNode.php
+++ b/src/parser/xhpast/api/XHPASTNode.php
@@ -149,7 +149,7 @@
$value = $this->getSemanticString();
$type = $value[0];
- $value = substr($value, 1, -1);
+ $value = preg_replace('/^b?[\'"]|[\'"]$/i', '', $value);
$esc = false;
$len = strlen($value);
$out = '';
diff --git a/src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php b/src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php
--- a/src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php
+++ b/src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php
@@ -33,6 +33,7 @@
$this->assertEval('simple string', "'simple string'");
$this->assertEval('42', "'42'");
+ $this->assertEval('binary string', "b'binary string'");
$this->assertEval(3.1415926, "3.1415926");
$this->assertEval(42, '42');
$this->assertEval(
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/kg/vw/tj7nmkypxohw52yo
Default Alt Text
D7662.diff (965 B)
Attached To
Mode
D7662: Support b'binary string' in XHPASTNode
Attached
Detach File
Event Timeline
Log In to Comment