Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F84233
D7616.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
855 B
Referenced Files
None
Subscribers
None
D7616.diff
View Options
diff --git a/scripts/arcanist.php b/scripts/arcanist.php
--- a/scripts/arcanist.php
+++ b/scripts/arcanist.php
@@ -304,10 +304,13 @@
} catch (PhutilMissingSymbolException $ex) {
// Continue anwyay, since you may otherwise be unable to run commands
// like `arc set-config events.listeners` in order to repair the damage
- // you've caused.
+ // you've caused. We're writing out the entire exception here because
+ // it might not have been triggered by the listener itself (for example,
+ // the listener might use a bad class in its register() method).
$console->writeErr(
- "ERROR: Failed to load event listener '%s'!\n",
- $listener);
+ "ERROR: Failed to load event listener '%s': %s\n",
+ $listener,
+ $ex->getMessage());
}
}
}
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/nj/xf/mrko25ohuwsqlpvq
Default Alt Text
D7616.diff (855 B)
Attached To
Mode
D7616: Improve exception raised when an event listener fails to load
Attached
Detach File
Event Timeline
Log In to Comment