Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F77318
D7453.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D7453.diff
View Options
diff --git a/src/applications/diffusion/query/DiffusionQuery.php b/src/applications/diffusion/query/DiffusionQuery.php
--- a/src/applications/diffusion/query/DiffusionQuery.php
+++ b/src/applications/diffusion/query/DiffusionQuery.php
@@ -99,8 +99,8 @@
$commits = mpull($commits, null, 'getCommitIdentifier');
// Build empty commit objects for every commit, so we can show unparsed
- // commits in history views as "unparsed" instead of not showing them. This
- // makes the process of importing and parsing commits much clearer to the
+ // commits in history views (as "Importing") instead of not showing them.
+ // This makes the process of importing and parsing commits clearer to the
// user.
$commit_list = array();
@@ -110,7 +110,6 @@
$commit_obj = new PhabricatorRepositoryCommit();
$commit_obj->setRepositoryID($repository->getID());
$commit_obj->setCommitIdentifier($identifier);
- $commit_obj->setIsUnparsed(true);
$commit_obj->makeEphemeral();
}
$commit_list[$identifier] = $commit_obj;
diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php
--- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php
@@ -25,7 +25,6 @@
private $commitData = self::ATTACHABLE;
private $audits;
- private $isUnparsed;
private $repository = self::ATTACHABLE;
public function attachRepository(PhabricatorRepository $repository) {
@@ -37,15 +36,6 @@
return $this->assertAttached($this->repository);
}
- public function setIsUnparsed($is_unparsed) {
- $this->isUnparsed = $is_unparsed;
- return $this;
- }
-
- public function getIsUnparsed() {
- return $this->isUnparsed;
- }
-
public function isImported() {
return ($this->getImportStatus() == self::IMPORTED_ALL);
}
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/ud/wz/mw4zknpwzieh4scz
Default Alt Text
D7453.diff (1 KB)
Attached To
Mode
D7453: Remove "isUnparsed" flag from commits
Attached
Detach File
Event Timeline
Log In to Comment