Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F76034
D7408.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D7408.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1485,6 +1485,7 @@
'PhabricatorPHDConfigOptions' => 'applications/config/option/PhabricatorPHDConfigOptions.php',
'PhabricatorPHID' => 'applications/phid/storage/PhabricatorPHID.php',
'PhabricatorPHIDConstants' => 'applications/phid/PhabricatorPHIDConstants.php',
+ 'PhabricatorPHIDInterface' => 'applications/phid/interface/PhabricatorPHIDInterface.php',
'PhabricatorPHIDType' => 'applications/phid/type/PhabricatorPHIDType.php',
'PhabricatorPHPMailerConfigOptions' => 'applications/config/option/PhabricatorPHPMailerConfigOptions.php',
'PhabricatorPagedFormExample' => 'applications/uiexample/examples/PhabricatorPagedFormExample.php',
@@ -3594,6 +3595,7 @@
'PhabricatorFlagQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
'PhabricatorFlagSearchEngine' => 'PhabricatorApplicationSearchEngine',
'PhabricatorFlagSelectControl' => 'AphrontFormControl',
+ 'PhabricatorFlaggableInterface' => 'PhabricatorPHIDInterface',
'PhabricatorFlagsUIEventListener' => 'PhabricatorEventListener',
'PhabricatorFormExample' => 'PhabricatorUIExample',
'PhabricatorGarbageCollectorConfigOptions' => 'PhabricatorApplicationConfigOptions',
@@ -3844,6 +3846,7 @@
'PhabricatorPolicyEditController' => 'PhabricatorPolicyController',
'PhabricatorPolicyException' => 'Exception',
'PhabricatorPolicyExplainController' => 'PhabricatorPolicyController',
+ 'PhabricatorPolicyInterface' => 'PhabricatorPHIDInterface',
'PhabricatorPolicyManagementShowWorkflow' => 'PhabricatorPolicyManagementWorkflow',
'PhabricatorPolicyManagementUnlockWorkflow' => 'PhabricatorPolicyManagementWorkflow',
'PhabricatorPolicyManagementWorkflow' => 'PhutilArgumentWorkflow',
diff --git a/src/applications/flag/interface/PhabricatorFlaggableInterface.php b/src/applications/flag/interface/PhabricatorFlaggableInterface.php
--- a/src/applications/flag/interface/PhabricatorFlaggableInterface.php
+++ b/src/applications/flag/interface/PhabricatorFlaggableInterface.php
@@ -1,7 +1,5 @@
<?php
-interface PhabricatorFlaggableInterface {
-
- public function getPHID();
+interface PhabricatorFlaggableInterface extends PhabricatorPHIDInterface {
}
diff --git a/src/applications/phid/interface/PhabricatorPHIDInterface.php b/src/applications/phid/interface/PhabricatorPHIDInterface.php
new file mode 100644
--- /dev/null
+++ b/src/applications/phid/interface/PhabricatorPHIDInterface.php
@@ -0,0 +1,7 @@
+<?php
+
+interface PhabricatorPHIDInterface {
+
+ public function getPHID();
+
+}
diff --git a/src/applications/policy/interface/PhabricatorPolicyInterface.php b/src/applications/policy/interface/PhabricatorPolicyInterface.php
--- a/src/applications/policy/interface/PhabricatorPolicyInterface.php
+++ b/src/applications/policy/interface/PhabricatorPolicyInterface.php
@@ -1,8 +1,7 @@
<?php
-interface PhabricatorPolicyInterface {
+interface PhabricatorPolicyInterface extends PhabricatorPHIDInterface {
- public function getPHID();
public function getCapabilities();
public function getPolicy($capability);
public function hasAutomaticCapability($capability, PhabricatorUser $viewer);
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/5x/yo/jkigxt7h56emc533
Default Alt Text
D7408.diff (3 KB)
Attached To
Mode
D7408: Work around a bug in PHP 5.3-ish with abstract methods in interfaces
Attached
Detach File
Event Timeline
Log In to Comment