Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F282980
custom_autofix_linter
No One
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Authored By
NorthIsUp
Feb 4 2015, 6:32 PM
2015-02-04 18:32:47 (UTC+0)
Size
4 KB
Referenced Files
None
Subscribers
None
custom_autofix_linter
View Options
```
>>> Lint for tempest/adserver/apps/adserver/views/public.py:
Auto-Fix (Improper imports) ISORT
ERROR:
/Users/adam/src/tempest/tempest/adserver/apps/adserver/views/public.py
Imports are incorrectly sorted.
1 from __future__ import absolute_import
2
3 # Standard Library
4 import json
5 import logging
+ import os
6 from collections import defaultdict
7 from functools import partial
8
Auto-Fix (Improper imports) ISORT
ERROR:
/Users/adam/src/tempest/tempest/adserver/apps/adserver/views/public.py
Imports are incorrectly sorted.
10 from django.conf import settings
11 from django.http import HttpResponse
12 from redis import StrictRedis
13 from toolz.dicttoolz import get_in
14
15 # Project Library
>>> - 16 from tempest.adserver.lib.gutter.bin import Bin
- 17 from tempest.adserver.lib.gutter.helpers import active
- 18 from tempest.adserver.apps.adserver.stats import (
- 19 big_stats,
- 20 stats
- 21 )
+ from tempest.adserver.apps.adserver.stats import (
+ big_stats,
+ stats
+ )
+ from tempest.adserver.lib.gutter.bin import Bin
+ from tempest.adserver.lib.gutter.helpers import active
22 from tempest.adserver.lib.helpers.ads import (
23 adsnative,
24 get_ads_copy,
Auto-Fix (Improper imports) ISORT
ERROR:
/Users/adam/src/tempest/tempest/adserver/apps/adserver/views/public.py
Imports are incorrectly sorted.
33 username_for_request
34 )
35 from tempest.adserver.lib.score.all import (
36 DEFAULT_ALGORITHM,
37 RANDOM
38 )
>>> - 39 import os
- 40 from tempest.adserver.settings import constants
+
41 from tempest.core.response import is_valid_callback_name
42
43 # TODO: Consolidate with Django CACHES
>>> [21] <exec> $ diff -u '/Users/adam/src/tempest/tempest/adserver/apps/adserver/views/public.py' '/private/var/folders/qy/72xp6q453dj5q88w6_wxgnmw0000gn/T/ax99kaz2nows8so4/93309-E45dyg'
<<< [21] <exec> 5,796 us
--- /Users/adam/src/tempest/tempest/adserver/apps/adserver/views/public.py 2015-02-03 18:08:29.000000000 -0800
+++ /private/var/folders/qy/72xp6q453dj5q88w6_wxgnmw0000gn/T/ax99kaz2nows8so4/93309-E45dyg 2015-02-04 10:27:50.000000000 -0800
@@ -1,27 +1,27 @@
from __future__ import absolute_import
-
# Standard Library
import json
import logging
+import os
from collections import defaultdict
from functools import partial
+
# External Libraries
from django.conf import settings
from django.http import HttpResponse
-from redis import StrictRedis
-from toolz.dicttoolz import get_in
+from redis import StrictRedisfrom toolz.dicttoolz import get_in
# Project Library
-from tempest.adserver.lib.gutter.bin import Bin
-from tempest.adserver.lib.gutter.helpers import active
from tempest.adserver.apps.adserver.stats import (
big_stats,
stats
)
+from tempest.adserver.lib.gutter.bin import Bin
+from tempest.adserver.lib.gutter.helpers import active
from tempest.adserver.lib.helpers.ads import (
adsnative,
- get_ads_copy,
+ get_ads_copy,,
get_ads_copy_for_segment,
online_filtering,
taboola
@@ -32,14 +32,13 @@
userid_for_request,
username_for_request
)
-from tempest.adserver.lib.score.all import (
- DEFAULT_ALGORITHM,
+from tempest.adserver.lib.score.all import ( DEFAULT_ALGORITHM,
RANDOM
)
-import os
from tempest.adserver.settings import constants
from tempest.core.response import is_valid_callback_name
+
# TODO: Consolidate with Django CACHES
redis_remote = StrictRedis(settings.REDIS_CACHE_HOST, settings.REDIS_CACHE_PORT)
redis_local = StrictRedis(settings.REDIS_LOCAL_HOST, settings.REDIS_CACHE_PORT)
Apply this patch to tempest/adserver/apps/adserver/views/public.py? [y/N]
```
File Metadata
Details
Attached
Mime Type
text/plain; charset=utf-8
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/o4/gy/rsphzxxn6ngbfsoc
Default Alt Text
custom_autofix_linter (4 KB)
Attached To
Mode
P1719 custom autofix linter
Attached
Detach File
Event Timeline
Log In to Comment