Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F19235241
D12858.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1012 B
Referenced Files
None
Subscribers
None
D12858.id.diff
View Options
diff --git a/resources/sql/autopatches/20150506.calendarunnamedevents.1.php b/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
--- a/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
+++ b/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
@@ -11,12 +11,17 @@
if (strlen($event->getName()) == 0) {
echo "Renaming event {$id}...\n";
$viewer = PhabricatorUser::getOmnipotentUser();
- $handle = id(new PhabricatorHandleQuery())
+
+ // NOTE: This uses PeopleQuery directly, instead of HandleQuery, to avoid
+ // performing cache fills as a side effect; the caches were added by a
+ // later patch. See T8209.
+ $user = id(new PhabricatorPeopleQuery())
->setViewer($viewer)
->withPHIDs(array($event->getUserPHID()))
->executeOne();
- if ($handle->isComplete()) {
- $new_name = $handle->getName();
+
+ if ($user) {
+ $new_name = $user->getUsername();
} else {
$new_name = pht('Unnamed Event');
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Dec 22 2025, 6:29 PM (9 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8703849
Default Alt Text
D12858.id.diff (1012 B)
Attached To
Mode
D12858: Don't use handles in the Calendar event name migration
Attached
Detach File
Event Timeline
Log In to Comment