Page MenuHomePhabricator

D12858.diff
No OneTemporary

D12858.diff

diff --git a/resources/sql/autopatches/20150506.calendarunnamedevents.1.php b/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
--- a/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
+++ b/resources/sql/autopatches/20150506.calendarunnamedevents.1.php
@@ -11,12 +11,17 @@
if (strlen($event->getName()) == 0) {
echo "Renaming event {$id}...\n";
$viewer = PhabricatorUser::getOmnipotentUser();
- $handle = id(new PhabricatorHandleQuery())
+
+ // NOTE: This uses PeopleQuery directly, instead of HandleQuery, to avoid
+ // performing cache fills as a side effect; the caches were added by a
+ // later patch. See T8209.
+ $user = id(new PhabricatorPeopleQuery())
->setViewer($viewer)
->withPHIDs(array($event->getUserPHID()))
->executeOne();
- if ($handle->isComplete()) {
- $new_name = $handle->getName();
+
+ if ($user) {
+ $new_name = $user->getUsername();
} else {
$new_name = pht('Unnamed Event');
}

File Metadata

Mime Type
text/plain
Expires
Dec 2 2025, 9:23 AM (12 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8703849
Default Alt Text
D12858.diff (1012 B)

Event Timeline