Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F19055996
D18718.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D18718.diff
View Options
diff --git a/src/applications/differential/render/DifferentialChangesetOneUpRenderer.php b/src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
--- a/src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
+++ b/src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
@@ -41,6 +41,20 @@
$column_width = 4;
+ $aural_minus = javelin_tag(
+ 'span',
+ array(
+ 'aural' => true,
+ ),
+ '- ');
+
+ $aural_plus = javelin_tag(
+ 'span',
+ array(
+ 'aural' => true,
+ ),
+ '+ ');
+
$out = array();
foreach ($primitives as $k => $p) {
$type = $p['type'];
@@ -55,8 +69,10 @@
if ($is_old) {
if ($p['htype']) {
$class = 'left old';
+ $aural = $aural_minus;
} else {
$class = 'left';
+ $aural = null;
}
if ($type == 'old-file') {
@@ -79,14 +95,20 @@
),
$line);
+ $render = $p['render'];
+ if ($aural !== null) {
+ $render = array($aural, $render);
+ }
+
$cells[] = phutil_tag('th', array('class' => $class));
$cells[] = $no_copy;
- $cells[] = phutil_tag('td', array('class' => $class), $p['render']);
+ $cells[] = phutil_tag('td', array('class' => $class), $render);
$cells[] = $no_coverage;
} else {
if ($p['htype']) {
$class = 'right new';
$cells[] = phutil_tag('th', array('class' => $class));
+ $aural = $aural_plus;
} else {
$class = 'right';
if ($left_prefix) {
@@ -98,6 +120,7 @@
$oline = $p['oline'];
$cells[] = phutil_tag('th', array('id' => $left_id), $oline);
+ $aural = null;
}
if ($type == 'new-file') {
@@ -120,8 +143,13 @@
),
$line);
+ $render = $p['render'];
+ if ($aural !== null) {
+ $render = array($aural, $render);
+ }
+
$cells[] = $no_copy;
- $cells[] = phutil_tag('td', array('class' => $class), $p['render']);
+ $cells[] = phutil_tag('td', array('class' => $class), $render);
$cells[] = $no_coverage;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Nov 29 2025, 6:50 PM (5 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8505831
Default Alt Text
D18718.diff (2 KB)
Attached To
Mode
D18718: Add aural "+" and "-" hints to unified diffs for users who use screenreaders
Attached
Detach File
Event Timeline
Log In to Comment