Page MenuHomePhabricator
Files F18850829

D8281.id19703.diff
No OneTemporary
Actions

D8281.id19703.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -123,7 +123,7 @@
'rsrc/css/layout/phabricator-hovercard-view.css' => '67c12b16',
'rsrc/css/layout/phabricator-side-menu-view.css' => '503699d0',
'rsrc/css/layout/phabricator-source-code-view.css' => '62a99814',
- 'rsrc/css/phui/phui-box.css' => '6c21bd6a',
+ 'rsrc/css/phui/phui-box.css' => '1a82a4ae',
'rsrc/css/phui/phui-button.css' => '8784a966',
'rsrc/css/phui/phui-calendar-month.css' => '3474d15a',
'rsrc/css/phui/phui-document.css' => '143b2ac8',
@@ -735,7 +735,7 @@
'phortune-credit-card-form-css' => 'b25b4beb',
'phrequent-css' => 'ffc185ad',
'phriction-document-css' => 'b0309d8e',
- 'phui-box-css' => '6c21bd6a',
+ 'phui-box-css' => '1a82a4ae',
'phui-button-css' => '8784a966',
'phui-calendar-month-css' => '3474d15a',
'phui-document-view-css' => '143b2ac8',
diff --git a/src/view/phui/PHUIBoxView.php b/src/view/phui/PHUIBoxView.php
--- a/src/view/phui/PHUIBoxView.php
+++ b/src/view/phui/PHUIBoxView.php
@@ -22,6 +22,7 @@
}
protected function getTagAttributes() {
+ require_celerity_resource('phui-box-css');
$outer_classes = array();
$outer_classes[] = 'phui-box';
if ($this->border) {
@@ -30,7 +31,9 @@
foreach ($this->margin as $margin) {
$outer_classes[] = $margin;
}
-
+ foreach ($this->padding as $padding) {
+ $outer_classes[] = $padding;
+ }
return array('class' => $outer_classes);
}
@@ -39,19 +42,6 @@
}
public function getTagContent() {
- require_celerity_resource('phui-box-css');
-
- $inner_classes = array();
- $inner_classes[] = 'phui-box-inner';
- foreach ($this->padding as $padding) {
- $inner_classes[] = $padding;
- }
-
- return phutil_tag(
- 'div',
- array(
- 'class' => implode(' ', $inner_classes)
- ),
- $this->renderChildren());
+ return $this->renderChildren();
}
}
diff --git a/webroot/rsrc/css/phui/phui-box.css b/webroot/rsrc/css/phui/phui-box.css
--- a/webroot/rsrc/css/phui/phui-box.css
+++ b/webroot/rsrc/css/phui/phui-box.css
@@ -5,9 +5,6 @@
.phui-box-border {
border: 1px solid {$lightblueborder};
border-bottom: 1px solid {$blueborder};
-}
-
-.phui-box-border .phui-box-inner {
background-color: #fff;
}

File Metadata

Mime Type
text/plain
Expires
Oct 31 2025, 7:38 PM (6 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
9090217
Default Alt Text
D8281.id19703.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility