Page MenuHomePhabricator
Files F18816831

D18408.diff
No OneTemporary
Actions

D18408.diff
View Options

diff --git a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
@@ -35,15 +35,11 @@
}
public function applyInternalEffects($object, $value) {
- $status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
- $status_accepted = ArcanistDifferentialRevisionStatus::ACCEPTED;
-
- $old_status = $object->getStatus();
+ $was_accepted = $object->isAccepted();
+ $status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
$object->setStatus($status_closed);
- $was_accepted = ($old_status == $status_accepted);
-
$object->setProperty(
DifferentialRevision::PROPERTY_CLOSED_FROM_ACCEPTED,
$was_accepted);
diff --git a/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php b/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
@@ -46,8 +46,7 @@
}
public function generateOldValue($object) {
- $status_planned = ArcanistDifferentialRevisionStatus::CHANGES_PLANNED;
- return ($object->getStatus() == $status_planned);
+ return $object->isChangePlanned();
}
public function applyInternalEffects($object, $value) {
diff --git a/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php b/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionRequestReviewTransaction.php
@@ -27,8 +27,7 @@
}
public function generateOldValue($object) {
- $status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW;
- return ($object->getStatus() == $status_review);
+ return $object->isNeedsReview();
}
public function applyInternalEffects($object, $value) {

File Metadata

Mime Type
text/plain
Expires
Wed, Oct 22, 9:43 AM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8541672
Default Alt Text
D18408.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility