Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F18788591
D8118.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
4 KB
Referenced Files
None
Subscribers
None
D8118.id.diff
View Options
Index: src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
===================================================================
--- src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
+++ src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
@@ -1,7 +1,7 @@
<?php
/**
- * Responds to "Whats new?" using the feed.
+ * Responds to "Whats new?" with some recent feed content
*
* @group irc
*/
@@ -10,135 +10,36 @@
private $floodblock = 0;
public function receiveMessage(PhabricatorBotMessage $message) {
-
switch ($message->getCommand()) {
case 'MESSAGE':
$message_body = $message->getBody();
+ $now = time();
$prompt = '~what( i|\')?s new\?~i';
if (preg_match($prompt, $message_body)) {
- if (time() < $this->floodblock) {
+ if ($now < $this->floodblock) {
return;
}
- $this->floodblock = time() + 60;
-
- $this->getLatest($message);
+ $this->floodblock = $now + 60;
+ $this->reportNew($message);
}
break;
}
}
- public function getLatest(PhabricatorBotMessage $message) {
+ public function reportNew(PhabricatorBotMessage $message) {
$latest = $this->getConduit()->callMethodSynchronous(
'feed.query',
array(
- 'limit' => 5
+ 'limit' => 5,
+ 'view' => 'text'
));
- $phids = array();
- foreach ($latest as $action) {
- if (isset($action['data']['actor_phid'])) {
- $uid = $action['data']['actor_phid'];
- } else {
- $uid = $action['authorPHID'];
+ foreach ($latest as $feed_item) {
+ if (isset($feed_item['text'])) {
+ $this->replyTo($message, html_entity_decode($feed_item['text']));
}
-
- switch ($action['class']) {
- case 'PhabricatorFeedStoryDifferential':
- $phids[] = $action['data']['revision_phid'];
- break;
- case 'PhabricatorFeedStoryAudit':
- $phids[] = $action['data']['commitPHID'];
- break;
-
- case 'PhabricatorFeedStoryManiphest':
- $phids[] = $action['data']['taskPHID'];
- break;
-
- default:
- $phids[] = $uid;
- break;
- }
- array_push($phids, $uid);
}
-
- $infs = $this->getConduit()->callMethodSynchronous(
- 'phid.query',
- array(
- 'phids'=>$phids
- ));
-
- $cphid = 0;
- foreach ($latest as $action) {
- if (isset($action['data']['actor_phid'])) {
- $uid = $action['data']['actor_phid'];
- } else {
- $uid = $action['authorPHID'];
- }
- switch ($action['class']) {
- case 'PhabricatorFeedStoryDifferential':
- $rinf = $infs[$action['data']['revision_phid']];
- break;
-
- case 'PhabricatorFeedStoryAudit':
- $rinf = $infs[$action['data']['commitPHID']];
- break;
-
- case 'PhabricatorFeedStoryManiphest':
- $rinf = $infs[$action['data']['taskPHID']];
- break;
-
- default:
- $rinf = array('name'=>$action['class']);
- break;
- }
- $uinf = $infs[$uid];
-
- $action = $this->getRhetoric($action['data']['action']);
- $user = $uinf['name'];
- $title = $rinf['fullName'];
- $uri = $rinf['uri'];
- $color = chr(3);
- $blue = $color.'12';
- $gray = $color.'15';
- $bold = chr(2);
- $reset = chr(15);
- // Disabling irc-specific styling, at least for now
- // $content = "{$bold}{$user}{$reset} {$gray}{$action} {$blue}{$bold}".
- // "{$title}{$reset} - {$gray}{$uri}{$reset}";
- $content = "{$user} {$action} {$title} - {$uri}";
- $this->replyTo($message, $content);
- }
- return;
}
- public function getRhetoric($input) {
- switch ($input) {
- case 'comment':
- case 'none':
- return 'commented on';
- break;
- case 'update':
- return 'updated';
- break;
- case 'commit':
- return 'closed';
- break;
- case 'create':
- return 'created';
- break;
- case 'concern':
- return 'raised concern for';
- break;
- case 'abandon':
- return 'abandonned';
- break;
- case 'accept':
- return 'accepted';
- break;
- default:
- return $input;
- break;
- }
- }
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Oct 16, 5:37 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8919721
Default Alt Text
D8118.id.diff (4 KB)
Attached To
Mode
D8118: Fix the `What's New?` phabricatorbot handler.
Attached
Detach File
Event Timeline
Log In to Comment