Page MenuHomePhabricator
Files F18774966

D8755.id20774.diff
No OneTemporary
Actions

D8755.id20774.diff
View Options

diff --git a/src/applications/differential/query/DifferentialRevisionQuery.php b/src/applications/differential/query/DifferentialRevisionQuery.php
--- a/src/applications/differential/query/DifferentialRevisionQuery.php
+++ b/src/applications/differential/query/DifferentialRevisionQuery.php
@@ -1030,11 +1030,11 @@
$viewer = $this->getViewer();
$viewer_phid = $viewer->getPHID();
+ $allow_key = 'differential.allow-self-accept';
+ $allow_self = PhabricatorEnv::getEnvConfig($allow_key);
// Figure out which of these reviewers the viewer has authority to act as.
if ($this->needReviewerAuthority && $viewer_phid) {
- $allow_key = 'differential.allow-self-accept';
- $allow_self = PhabricatorEnv::getEnvConfig($allow_key);
$authority = $this->loadReviewerAuthority(
$revisions,
$edges,
@@ -1072,7 +1072,6 @@
}
-
public static function splitResponsible(array $revisions, array $user_phids) {
$blocking = array();
$active = array();
@@ -1087,6 +1086,11 @@
$filter_is_author = in_array($revision->getAuthorPHID(), $user_phids);
if (!$revision->getReviewers()) {
$needs_review = false;
+ $author_is_reviewer = false;
+ } else {
+ $author_is_reviewer = in_array(
+ $revision->getAuthorPHID(),
+ $revision->getReviewers());
}
// If exactly one of "needs review" and "the user is the author" is
@@ -1098,6 +1102,11 @@
} else {
$active[] = $revision;
}
+ // User is author **and** reviewer. An exotic but configurable workflow.
+ // User needs to act on it double.
+ } else if ($needs_review && $author_is_reviewer) {
+ array_unshift($blocking, $revision);
+ $active[] = $revision;
} else {
$waiting[] = $revision;
}

File Metadata

Mime Type
text/plain
Expires
Oct 11 2025, 5:30 PM (12 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8611999
Default Alt Text
D8755.id20774.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility