Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F18773041
D12666.id30427.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
4 KB
Referenced Files
None
Subscribers
None
D12666.id30427.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -319,7 +319,6 @@
'PhutilSyntaxHighlighterException' => 'markup/syntax/highlighter/PhutilSyntaxHighlighterException.php',
'PhutilSystem' => 'utils/PhutilSystem.php',
'PhutilSystemTestCase' => 'utils/__tests__/PhutilSystemTestCase.php',
- 'PhutilTestCase' => 'infrastructure/testing/PhutilTestCase.php',
'PhutilTestPhobject' => 'object/__tests__/PhutilTestPhobject.php',
'PhutilTortureTestDaemon' => 'daemon/torture/PhutilTortureTestDaemon.php',
'PhutilTranslation' => 'internationalization/PhutilTranslation.php',
@@ -717,7 +716,6 @@
'PhutilSyntaxHighlighterException' => 'Exception',
'PhutilSystem' => 'Phobject',
'PhutilSystemTestCase' => 'PhutilTestCase',
- 'PhutilTestCase' => 'ArcanistPhutilTestCase',
'PhutilTestPhobject' => 'Phobject',
'PhutilTortureTestDaemon' => 'PhutilDaemon',
'PhutilTranslation' => 'Phobject',
diff --git a/src/filesystem/__tests__/FileFinderTestCase.php b/src/filesystem/__tests__/FileFinderTestCase.php
--- a/src/filesystem/__tests__/FileFinderTestCase.php
+++ b/src/filesystem/__tests__/FileFinderTestCase.php
@@ -5,7 +5,7 @@
protected function getFinder() {
$finder = new FileFinder(dirname(__FILE__).'/data');
$finder->excludePath('./exclude')
- ->excludePath('subdir.txt');
+ ->excludePath('subdir.txt');
return $finder;
}
@@ -23,9 +23,9 @@
$this->assertTrue(array_key_exists('test.txt', $files));
$this->assertTrue(array_key_exists('file.txt', $files));
$this->assertTrue(
- array_key_exists(
- 'include_dir.txt/subdir.txt/alsoinclude.txt',
- $files));
+ array_key_exists(
+ 'include_dir.txt/subdir.txt/alsoinclude.txt',
+ $files));
$this->assertFalse(array_key_exists('test', $files));
$this->assertTrue(array_key_exists('.hidden.txt', $files));
$this->assertFalse(array_key_exists('exclude/file.txt', $files));
@@ -65,7 +65,7 @@
$this->assertTrue(in_array('file.txt', $files));
$this->assertTrue(in_array('.hidden.txt', $files));
$this->assertTrue(
- in_array('include_dir.txt/subdir.txt/alsoinclude.txt', $files));
+ in_array('include_dir.txt/subdir.txt/alsoinclude.txt', $files));
$this->assertFalse(in_array('test', $files));
$this->assertFalse(in_array('exclude/file.txt', $files));
$this->assertFalse(in_array('include_dir.txt', $files));
@@ -89,9 +89,9 @@
$this->assertTrue(array_key_exists('test.txt', $files));
$this->assertTrue(array_key_exists('file.txt', $files));
$this->assertTrue(
- array_key_exists(
- 'include_dir.txt/subdir.txt/alsoinclude.txt',
- $files));
+ array_key_exists(
+ 'include_dir.txt/subdir.txt/alsoinclude.txt',
+ $files));
$this->assertFalse(array_key_exists('test', $files));
$this->assertTrue(array_key_exists('.hidden.txt', $files));
$this->assertFalse(array_key_exists('exclude/file.txt', $files));
@@ -116,9 +116,9 @@
// Test whether the correct files were found.
$this->assertTrue(
- array_key_exists(
- 'include_dir.txt/subdir.txt/alsoinclude.txt',
- $files));
+ array_key_exists(
+ 'include_dir.txt/subdir.txt/alsoinclude.txt',
+ $files));
// Ensure that only the one file was found.
$this->assertEqual(1, count($files));
}
diff --git a/src/infrastructure/testing/PhutilTestCase.php b/src/infrastructure/testing/PhutilTestCase.php
deleted file mode 100644
--- a/src/infrastructure/testing/PhutilTestCase.php
+++ /dev/null
@@ -1,13 +0,0 @@
-<?php
-
-abstract class PhutilTestCase extends ArcanistPhutilTestCase {
-
- protected function getLink($method) {
- $libphutil_project = 'PHID-APRJ-8d75d09d9c1e15afec3d';
- return
- 'https://secure.phabricator.com/diffusion/symbol/'.$method.
- '/?lang=php&projects='.$libphutil_project.
- '&jump=true&context='.get_class($this);
- }
-
-}
diff --git a/src/lexer/__tests__/PhutilSimpleOptionsLexerTestCase.php b/src/lexer/__tests__/PhutilSimpleOptionsLexerTestCase.php
--- a/src/lexer/__tests__/PhutilSimpleOptionsLexerTestCase.php
+++ b/src/lexer/__tests__/PhutilSimpleOptionsLexerTestCase.php
@@ -23,8 +23,6 @@
array('word', '4', null),
),
$this->getTokens('legs=4, LEGS=4'));
-
-
}
public function testSimpleOptionsLexerNiceTokens() {
diff --git a/src/utils/__tests__/PhutilLunarPhaseTestCase.php b/src/utils/__tests__/PhutilLunarPhaseTestCase.php
--- a/src/utils/__tests__/PhutilLunarPhaseTestCase.php
+++ b/src/utils/__tests__/PhutilLunarPhaseTestCase.php
@@ -3,7 +3,6 @@
final class PhutilLunarPhaseTestCase extends PhutilTestCase {
public function testLunarPhases() {
-
// Aug 11, 1999
$moon = new PhutilLunarPhase(934354800);
$this->assertFalse($moon->isFull());
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Oct 10 2025, 6:37 AM (14 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
9042413
Default Alt Text
D12666.id30427.diff (4 KB)
Attached To
Mode
D12666: Remove PhutilTestCase class
Attached
Detach File
Event Timeline
Log In to Comment