Page MenuHomePhabricator
Files F18764262

D13308.id32203.diff
No OneTemporary
Actions

D13308.id32203.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -103,7 +103,7 @@
'rsrc/css/application/releeph/releeph-preview-branch.css' => 'b7a6f4a5',
'rsrc/css/application/releeph/releeph-request-differential-create-dialog.css' => '8d8b92cd',
'rsrc/css/application/releeph/releeph-request-typeahead.css' => '667a48ae',
- 'rsrc/css/application/search/search-results.css' => 'ce897fb9',
+ 'rsrc/css/application/search/search-results.css' => '7dea472c',
'rsrc/css/application/slowvote/slowvote.css' => '266df6a1',
'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
'rsrc/css/application/uiexample/example.css' => '528b19de',
@@ -731,7 +731,7 @@
'phabricator-phtize' => 'd254d646',
'phabricator-prefab' => '6920d200',
'phabricator-remarkup-css' => '13368efd',
- 'phabricator-search-results-css' => 'ce897fb9',
+ 'phabricator-search-results-css' => '7dea472c',
'phabricator-shaped-request' => '7cbe244b',
'phabricator-side-menu-view-css' => '4f2cd343',
'phabricator-slowvote-css' => '266df6a1',
diff --git a/src/applications/search/controller/PhabricatorApplicationSearchController.php b/src/applications/search/controller/PhabricatorApplicationSearchController.php
--- a/src/applications/search/controller/PhabricatorApplicationSearchController.php
+++ b/src/applications/search/controller/PhabricatorApplicationSearchController.php
@@ -193,7 +193,8 @@
pht('Edit Query'),
pht('Hide Query'),
$form,
- $this->getApplicationURI('query/advanced/?query='.$query_key));
+ $this->getApplicationURI('query/advanced/?query='.$query_key),
+ (!$named_query ? true : false));
} else {
$box->setForm($form);
}
diff --git a/src/view/phui/PHUIObjectBoxView.php b/src/view/phui/PHUIObjectBoxView.php
--- a/src/view/phui/PHUIObjectBoxView.php
+++ b/src/view/phui/PHUIObjectBoxView.php
@@ -24,6 +24,7 @@
private $hideAction;
private $showHideHref;
private $showHideContent;
+ private $showHideOpen;
private $tabs = array();
private $propertyLists = array();
@@ -173,11 +174,12 @@
return $this;
}
- public function setShowHide($show, $hide, $content, $href) {
+ public function setShowHide($show, $hide, $content, $href, $open = false) {
$this->showAction = $show;
$this->hideAction = $hide;
$this->showHideContent = $content;
$this->showHideHref = $href;
+ $this->showHideOpen = $open;
return $this;
}
@@ -205,10 +207,13 @@
$show_action_id = celerity_generate_unique_node_id();
$content_id = celerity_generate_unique_node_id();
+ $hide_style = ($this->showHideOpen ? 'display: none;': null);
+ $show_style = ($this->showHideOpen ? null : 'display: none;');
$hide_action = id(new PHUIButtonView())
->setTag('a')
->addSigil('reveal-content')
->setID($hide_action_id)
+ ->setStyle($hide_style)
->setHref($this->showHideHref)
->setMetaData(
array(
@@ -220,7 +225,7 @@
$show_action = id(new PHUIButtonView())
->setTag('a')
->addSigil('reveal-content')
- ->setStyle('display: none;')
+ ->setStyle($show_style)
->setHref('#')
->setID($show_action_id)
->setMetaData(
@@ -239,7 +244,7 @@
array(
'class' => 'phui-object-box-hidden-content',
'id' => $content_id,
- 'style' => 'display: none;',
+ 'style' => $show_style,
),
$this->showHideContent),
);
@@ -352,7 +357,7 @@
$content = id(new PHUIBoxView())
->appendChild(
array(
- $this->anchor,
+ ($this->showHideOpen == false ? $this->anchor : null),
$header,
$this->infoView,
$this->formErrors,
@@ -362,6 +367,7 @@
$tabs,
$tab_lists,
$showhide,
+ ($this->showHideOpen == true ? $this->anchor : null),
$property_lists,
$this->table,
$this->renderChildren(),
diff --git a/webroot/rsrc/css/application/search/search-results.css b/webroot/rsrc/css/application/search/search-results.css
--- a/webroot/rsrc/css/application/search/search-results.css
+++ b/webroot/rsrc/css/application/search/search-results.css
@@ -4,6 +4,7 @@
.phui-object-item-link strong {
color: {$fire};
+ text-decoration: underline;
}
.phui-source-fragment {

File Metadata

Mime Type
text/plain
Expires
Wed, Oct 8, 5:10 AM (2 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8811313
Default Alt Text
D13308.id32203.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility