Page MenuHomePhabricator
Files F18734893

D9224.id.diff
No OneTemporary
Actions

D9224.id.diff
View Options

diff --git a/src/applications/search/controller/PhabricatorApplicationSearchController.php b/src/applications/search/controller/PhabricatorApplicationSearchController.php
--- a/src/applications/search/controller/PhabricatorApplicationSearchController.php
+++ b/src/applications/search/controller/PhabricatorApplicationSearchController.php
@@ -177,15 +177,20 @@
$form->appendChild($submit);
$filter_view = id(new AphrontListFilterView())->appendChild($form);
- if ($run_query && $named_query) {
- if ($named_query->getIsBuiltin()) {
- $description = pht(
- 'Showing results for query "%s".',
- $named_query->getQueryName());
+ if ($run_query) {
+ if ($named_query) {
+ if ($named_query->getIsBuiltin()) {
+ $description = pht(
+ 'Showing results for query "%s".',
+ $named_query->getQueryName());
+ } else {
+ $description = pht(
+ 'Showing results for saved query "%s".',
+ $named_query->getQueryName());
+ }
} else {
$description = pht(
- 'Showing results for saved query "%s".',
- $named_query->getQueryName());
+ 'Showing results for advanced search.');
}
$filter_view->setCollapsed(
@@ -343,6 +348,28 @@
$nav->selectFilter('query/edit');
$nav->setCrumbs($crumbs);
+ $instructions_raw = pht(
+ 'Drag and drop the existing queries below to re-order them in the '.
+ 'queries list. The queries list will be re-ordered on page reload.'.
+ "\n\n".
+ 'New queries can be created from "Advanced Search" results as follows: '.
+ "\n".
+ ' - Execute an "Advanced Search."'."\n".
+ ' - Click the "Edit Query..." button at the top of the page.'."\n".
+ ' - Click the "Save Custom Query..." button in the "Edit Query..." '.
+ 'form.'."\n".
+ ' - Give the query a name and click the "Save Query" button.');
+ $instructions_remarkup = PhabricatorMarkupEngine::renderOneObject(
+ id(new PhabricatorMarkupOneOff())->setContent($instructions_raw),
+ 'default',
+ $user);
+
+ $instructions = id(new PHUIBoxView())
+ ->addPadding(PHUI::PADDING_LARGE)
+ ->addMargin(PHUI::MARGIN_LARGE)
+ ->setBorder(true)
+ ->appendChild($instructions_remarkup);
+ $nav->appendChild($instructions);
$nav->appendChild($list);
return $parent->buildApplicationPage(

File Metadata

Mime Type
text/plain
Expires
Oct 1 2025, 11:05 PM (14 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8812263
Default Alt Text
D9224.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility