D10725.id.diff
No OneTemporary
Actions

Size

974 B

Referenced Files

None

Subscribers

None

D10725.id.diff
View Options

	diff --git a/src/applications/pholio/editor/PholioMockEditor.php b/src/applications/pholio/editor/PholioMockEditor.php
	--- a/src/applications/pholio/editor/PholioMockEditor.php
	+++ b/src/applications/pholio/editor/PholioMockEditor.php
	@@ -462,18 +462,17 @@
	HeraldAdapter $adapter,
	HeraldTranscript $transcript) {

	- // TODO: Convert this to be transaction-based.
	+ $xactions = array();

	$cc_phids = $adapter->getCcPHIDs();
	if ($cc_phids) {
	- id(new PhabricatorSubscriptionsEditor())
	- ->setObject($object)
	- ->setActor($this->requireActor())
	- ->subscribeImplicit($cc_phids)
	- ->save();
	+ $value = array_fuse($cc_phids);
	+ $xactions[] = id(new PholioTransaction())
	+ ->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS)
	+ ->setNewValue(array('+' => $value));
	}

	- return array();
	+ return $xactions;
	}

	protected function sortTransactions(array $xactions) {