Page MenuHomePhabricator
Files F18363529

D11241.diff
No OneTemporary
Actions

D11241.diff
View Options

diff --git a/src/applications/almanac/controller/AlmanacDeviceController.php b/src/applications/almanac/controller/AlmanacDeviceController.php
--- a/src/applications/almanac/controller/AlmanacDeviceController.php
+++ b/src/applications/almanac/controller/AlmanacDeviceController.php
@@ -2,7 +2,7 @@
abstract class AlmanacDeviceController extends AlmanacController {
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$list_uri = $this->getApplicationURI('device/');
diff --git a/src/applications/almanac/controller/AlmanacDeviceListController.php b/src/applications/almanac/controller/AlmanacDeviceListController.php
--- a/src/applications/almanac/controller/AlmanacDeviceListController.php
+++ b/src/applications/almanac/controller/AlmanacDeviceListController.php
@@ -16,7 +16,7 @@
return $this->delegateToController($controller);
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(
diff --git a/src/applications/almanac/controller/AlmanacNetworkController.php b/src/applications/almanac/controller/AlmanacNetworkController.php
--- a/src/applications/almanac/controller/AlmanacNetworkController.php
+++ b/src/applications/almanac/controller/AlmanacNetworkController.php
@@ -2,7 +2,7 @@
abstract class AlmanacNetworkController extends AlmanacController {
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$list_uri = $this->getApplicationURI('network/');
diff --git a/src/applications/almanac/controller/AlmanacNetworkListController.php b/src/applications/almanac/controller/AlmanacNetworkListController.php
--- a/src/applications/almanac/controller/AlmanacNetworkListController.php
+++ b/src/applications/almanac/controller/AlmanacNetworkListController.php
@@ -16,7 +16,7 @@
return $this->delegateToController($controller);
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(
diff --git a/src/applications/almanac/controller/AlmanacServiceController.php b/src/applications/almanac/controller/AlmanacServiceController.php
--- a/src/applications/almanac/controller/AlmanacServiceController.php
+++ b/src/applications/almanac/controller/AlmanacServiceController.php
@@ -2,7 +2,7 @@
abstract class AlmanacServiceController extends AlmanacController {
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$list_uri = $this->getApplicationURI('service/');
diff --git a/src/applications/almanac/controller/AlmanacServiceListController.php b/src/applications/almanac/controller/AlmanacServiceListController.php
--- a/src/applications/almanac/controller/AlmanacServiceListController.php
+++ b/src/applications/almanac/controller/AlmanacServiceListController.php
@@ -16,7 +16,7 @@
return $this->delegateToController($controller);
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(
diff --git a/src/applications/audit/controller/PhabricatorAuditController.php b/src/applications/audit/controller/PhabricatorAuditController.php
--- a/src/applications/audit/controller/PhabricatorAuditController.php
+++ b/src/applications/audit/controller/PhabricatorAuditController.php
@@ -18,7 +18,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
}
diff --git a/src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php b/src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php
--- a/src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php
+++ b/src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php
@@ -20,7 +20,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView($for_app = true)->getMenu();
}
diff --git a/src/applications/calendar/controller/PhabricatorCalendarController.php b/src/applications/calendar/controller/PhabricatorCalendarController.php
--- a/src/applications/calendar/controller/PhabricatorCalendarController.php
+++ b/src/applications/calendar/controller/PhabricatorCalendarController.php
@@ -20,11 +20,11 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/config/controller/PhabricatorConfigController.php b/src/applications/config/controller/PhabricatorConfigController.php
--- a/src/applications/config/controller/PhabricatorConfigController.php
+++ b/src/applications/config/controller/PhabricatorConfigController.php
@@ -26,7 +26,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(null, true)->getMenu();
}
diff --git a/src/applications/conpherence/controller/ConpherenceController.php b/src/applications/conpherence/controller/ConpherenceController.php
--- a/src/applications/conpherence/controller/ConpherenceController.php
+++ b/src/applications/conpherence/controller/ConpherenceController.php
@@ -4,7 +4,7 @@
private $conpherences;
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
$nav = new PHUIListView();
$nav->newLink(
@@ -30,7 +30,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs
diff --git a/src/applications/countdown/controller/PhabricatorCountdownController.php b/src/applications/countdown/controller/PhabricatorCountdownController.php
--- a/src/applications/countdown/controller/PhabricatorCountdownController.php
+++ b/src/applications/countdown/controller/PhabricatorCountdownController.php
@@ -21,11 +21,11 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView($for_app = true)->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/dashboard/controller/PhabricatorDashboardListController.php b/src/applications/dashboard/controller/PhabricatorDashboardListController.php
--- a/src/applications/dashboard/controller/PhabricatorDashboardListController.php
+++ b/src/applications/dashboard/controller/PhabricatorDashboardListController.php
@@ -39,7 +39,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/dashboard/controller/PhabricatorDashboardPanelListController.php b/src/applications/dashboard/controller/PhabricatorDashboardPanelListController.php
--- a/src/applications/dashboard/controller/PhabricatorDashboardPanelListController.php
+++ b/src/applications/dashboard/controller/PhabricatorDashboardPanelListController.php
@@ -36,7 +36,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Panels'), $this->getApplicationURI().'panel/');
diff --git a/src/applications/dashboard/controller/PhabricatorDashboardViewController.php b/src/applications/dashboard/controller/PhabricatorDashboardViewController.php
--- a/src/applications/dashboard/controller/PhabricatorDashboardViewController.php
+++ b/src/applications/dashboard/controller/PhabricatorDashboardViewController.php
@@ -49,7 +49,7 @@
));
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$id = $this->id;
diff --git a/src/applications/differential/controller/DifferentialController.php b/src/applications/differential/controller/DifferentialController.php
--- a/src/applications/differential/controller/DifferentialController.php
+++ b/src/applications/differential/controller/DifferentialController.php
@@ -2,7 +2,7 @@
abstract class DifferentialController extends PhabricatorController {
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
@@ -29,7 +29,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditController.php
@@ -3,7 +3,7 @@
abstract class DiffusionRepositoryEditController
extends DiffusionController {
- public function buildApplicationCrumbs($is_main = false) {
+ protected function buildApplicationCrumbs($is_main = false) {
$crumbs = parent::buildApplicationCrumbs();
if ($this->diffusionRequest) {
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryListController.php b/src/applications/diffusion/controller/DiffusionRepositoryListController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryListController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryListController.php
@@ -37,7 +37,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(
diff --git a/src/applications/drydock/controller/DrydockBlueprintController.php b/src/applications/drydock/controller/DrydockBlueprintController.php
--- a/src/applications/drydock/controller/DrydockBlueprintController.php
+++ b/src/applications/drydock/controller/DrydockBlueprintController.php
@@ -16,7 +16,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
pht('Blueprints'),
diff --git a/src/applications/drydock/controller/DrydockBlueprintListController.php b/src/applications/drydock/controller/DrydockBlueprintListController.php
--- a/src/applications/drydock/controller/DrydockBlueprintListController.php
+++ b/src/applications/drydock/controller/DrydockBlueprintListController.php
@@ -22,7 +22,7 @@
return $this->delegateToController($controller);
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$can_create = $this->hasApplicationCapability(
DrydockCreateBlueprintsCapability::CAPABILITY);
diff --git a/src/applications/drydock/controller/DrydockController.php b/src/applications/drydock/controller/DrydockController.php
--- a/src/applications/drydock/controller/DrydockController.php
+++ b/src/applications/drydock/controller/DrydockController.php
@@ -4,7 +4,7 @@
abstract function buildSideNavView();
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
}
diff --git a/src/applications/drydock/controller/DrydockLeaseController.php b/src/applications/drydock/controller/DrydockLeaseController.php
--- a/src/applications/drydock/controller/DrydockLeaseController.php
+++ b/src/applications/drydock/controller/DrydockLeaseController.php
@@ -16,7 +16,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
pht('Leases'),
diff --git a/src/applications/drydock/controller/DrydockLogController.php b/src/applications/drydock/controller/DrydockLogController.php
--- a/src/applications/drydock/controller/DrydockLogController.php
+++ b/src/applications/drydock/controller/DrydockLogController.php
@@ -16,7 +16,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
pht('Logs'),
diff --git a/src/applications/drydock/controller/DrydockResourceController.php b/src/applications/drydock/controller/DrydockResourceController.php
--- a/src/applications/drydock/controller/DrydockResourceController.php
+++ b/src/applications/drydock/controller/DrydockResourceController.php
@@ -16,7 +16,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
pht('Resources'),
diff --git a/src/applications/files/controller/PhabricatorFileListController.php b/src/applications/files/controller/PhabricatorFileListController.php
--- a/src/applications/files/controller/PhabricatorFileListController.php
+++ b/src/applications/files/controller/PhabricatorFileListController.php
@@ -21,7 +21,7 @@
return $this->delegateToController($controller);
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
id(new PHUIListItemView())
diff --git a/src/applications/fund/controller/FundInitiativeListController.php b/src/applications/fund/controller/FundInitiativeListController.php
--- a/src/applications/fund/controller/FundInitiativeListController.php
+++ b/src/applications/fund/controller/FundInitiativeListController.php
@@ -40,7 +40,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(
diff --git a/src/applications/harbormaster/controller/HarbormasterBuildableListController.php b/src/applications/harbormaster/controller/HarbormasterBuildableListController.php
--- a/src/applications/harbormaster/controller/HarbormasterBuildableListController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildableListController.php
@@ -39,7 +39,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
diff --git a/src/applications/harbormaster/controller/HarbormasterController.php b/src/applications/harbormaster/controller/HarbormasterController.php
--- a/src/applications/harbormaster/controller/HarbormasterController.php
+++ b/src/applications/harbormaster/controller/HarbormasterController.php
@@ -2,7 +2,7 @@
abstract class HarbormasterController extends PhabricatorController {
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/harbormaster/controller/HarbormasterPlanController.php b/src/applications/harbormaster/controller/HarbormasterPlanController.php
--- a/src/applications/harbormaster/controller/HarbormasterPlanController.php
+++ b/src/applications/harbormaster/controller/HarbormasterPlanController.php
@@ -2,7 +2,7 @@
abstract class HarbormasterPlanController extends HarbormasterController {
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
diff --git a/src/applications/harbormaster/controller/HarbormasterPlanListController.php b/src/applications/harbormaster/controller/HarbormasterPlanListController.php
--- a/src/applications/harbormaster/controller/HarbormasterPlanListController.php
+++ b/src/applications/harbormaster/controller/HarbormasterPlanListController.php
@@ -40,7 +40,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
diff --git a/src/applications/herald/controller/HeraldController.php b/src/applications/herald/controller/HeraldController.php
--- a/src/applications/herald/controller/HeraldController.php
+++ b/src/applications/herald/controller/HeraldController.php
@@ -16,11 +16,11 @@
return $response->setContent($page->render());
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/herald/controller/HeraldTranscriptListController.php b/src/applications/herald/controller/HeraldTranscriptListController.php
--- a/src/applications/herald/controller/HeraldTranscriptListController.php
+++ b/src/applications/herald/controller/HeraldTranscriptListController.php
@@ -23,7 +23,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
diff --git a/src/applications/legalpad/controller/LegalpadController.php b/src/applications/legalpad/controller/LegalpadController.php
--- a/src/applications/legalpad/controller/LegalpadController.php
+++ b/src/applications/legalpad/controller/LegalpadController.php
@@ -22,7 +22,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNav(true)->getMenu();
}
diff --git a/src/applications/legalpad/controller/LegalpadDocumentListController.php b/src/applications/legalpad/controller/LegalpadDocumentListController.php
--- a/src/applications/legalpad/controller/LegalpadDocumentListController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentListController.php
@@ -21,7 +21,7 @@
return $this->delegateToController($controller);
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(
diff --git a/src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php b/src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php
--- a/src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php
@@ -64,7 +64,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
if ($this->document) {
diff --git a/src/applications/macro/controller/PhabricatorMacroController.php b/src/applications/macro/controller/PhabricatorMacroController.php
--- a/src/applications/macro/controller/PhabricatorMacroController.php
+++ b/src/applications/macro/controller/PhabricatorMacroController.php
@@ -20,7 +20,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView($for_app = true)->getMenu();
}
diff --git a/src/applications/mailinglists/controller/PhabricatorMailingListsController.php b/src/applications/mailinglists/controller/PhabricatorMailingListsController.php
--- a/src/applications/mailinglists/controller/PhabricatorMailingListsController.php
+++ b/src/applications/mailinglists/controller/PhabricatorMailingListsController.php
@@ -21,11 +21,11 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/meta/controller/PhabricatorApplicationsController.php b/src/applications/meta/controller/PhabricatorApplicationsController.php
--- a/src/applications/meta/controller/PhabricatorApplicationsController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationsController.php
@@ -17,7 +17,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
diff --git a/src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php b/src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php
--- a/src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php
+++ b/src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php
@@ -22,7 +22,7 @@
return $this->delegateToController($controller);
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/owners/controller/PhabricatorOwnersController.php b/src/applications/owners/controller/PhabricatorOwnersController.php
--- a/src/applications/owners/controller/PhabricatorOwnersController.php
+++ b/src/applications/owners/controller/PhabricatorOwnersController.php
@@ -58,7 +58,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
}
diff --git a/src/applications/passphrase/controller/PassphraseController.php b/src/applications/passphrase/controller/PassphraseController.php
--- a/src/applications/passphrase/controller/PassphraseController.php
+++ b/src/applications/passphrase/controller/PassphraseController.php
@@ -21,11 +21,11 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/paste/controller/PhabricatorPasteController.php b/src/applications/paste/controller/PhabricatorPasteController.php
--- a/src/applications/paste/controller/PhabricatorPasteController.php
+++ b/src/applications/paste/controller/PhabricatorPasteController.php
@@ -21,11 +21,11 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/people/controller/PhabricatorPeopleController.php b/src/applications/people/controller/PhabricatorPeopleController.php
--- a/src/applications/people/controller/PhabricatorPeopleController.php
+++ b/src/applications/people/controller/PhabricatorPeopleController.php
@@ -28,11 +28,11 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView()->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$viewer = $this->getRequest()->getUser();
diff --git a/src/applications/phame/controller/PhameController.php b/src/applications/phame/controller/PhameController.php
--- a/src/applications/phame/controller/PhameController.php
+++ b/src/applications/phame/controller/PhameController.php
@@ -103,7 +103,7 @@
return $stories;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->renderSideNavFilterView()->getMenu();
}
diff --git a/src/applications/pholio/controller/PholioController.php b/src/applications/pholio/controller/PholioController.php
--- a/src/applications/pholio/controller/PholioController.php
+++ b/src/applications/pholio/controller/PholioController.php
@@ -21,7 +21,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
@@ -33,7 +33,7 @@
return $crumbs;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
diff --git a/src/applications/phortune/controller/PhortuneCartListController.php b/src/applications/phortune/controller/PhortuneCartListController.php
--- a/src/applications/phortune/controller/PhortuneCartListController.php
+++ b/src/applications/phortune/controller/PhortuneCartListController.php
@@ -79,7 +79,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$merchant = $this->merchant;
diff --git a/src/applications/phortune/controller/PhortuneChargeListController.php b/src/applications/phortune/controller/PhortuneChargeListController.php
--- a/src/applications/phortune/controller/PhortuneChargeListController.php
+++ b/src/applications/phortune/controller/PhortuneChargeListController.php
@@ -61,7 +61,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$account = $this->account;
diff --git a/src/applications/phortune/controller/PhortuneMerchantController.php b/src/applications/phortune/controller/PhortuneMerchantController.php
--- a/src/applications/phortune/controller/PhortuneMerchantController.php
+++ b/src/applications/phortune/controller/PhortuneMerchantController.php
@@ -3,7 +3,7 @@
abstract class PhortuneMerchantController
extends PhortuneController {
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addTextCrumb(
pht('Merchants'),
diff --git a/src/applications/phortune/controller/PhortuneMerchantListController.php b/src/applications/phortune/controller/PhortuneMerchantListController.php
--- a/src/applications/phortune/controller/PhortuneMerchantListController.php
+++ b/src/applications/phortune/controller/PhortuneMerchantListController.php
@@ -37,7 +37,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(
diff --git a/src/applications/phriction/controller/PhrictionController.php b/src/applications/phriction/controller/PhrictionController.php
--- a/src/applications/phriction/controller/PhrictionController.php
+++ b/src/applications/phriction/controller/PhrictionController.php
@@ -22,11 +22,11 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
if (get_class($this) != 'PhrictionListController') {
diff --git a/src/applications/ponder/controller/PonderController.php b/src/applications/ponder/controller/PonderController.php
--- a/src/applications/ponder/controller/PonderController.php
+++ b/src/applications/ponder/controller/PonderController.php
@@ -17,7 +17,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs
->addAction(
diff --git a/src/applications/project/controller/PhabricatorProjectListController.php b/src/applications/project/controller/PhabricatorProjectListController.php
--- a/src/applications/project/controller/PhabricatorProjectListController.php
+++ b/src/applications/project/controller/PhabricatorProjectListController.php
@@ -22,11 +22,11 @@
return $this->delegateToController($controller);
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$can_create = $this->hasApplicationCapability(
diff --git a/src/applications/releeph/controller/ReleephController.php b/src/applications/releeph/controller/ReleephController.php
--- a/src/applications/releeph/controller/ReleephController.php
+++ b/src/applications/releeph/controller/ReleephController.php
@@ -34,7 +34,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
diff --git a/src/applications/releeph/controller/branch/ReleephBranchViewController.php b/src/applications/releeph/controller/branch/ReleephBranchViewController.php
--- a/src/applications/releeph/controller/branch/ReleephBranchViewController.php
+++ b/src/applications/releeph/controller/branch/ReleephBranchViewController.php
@@ -103,7 +103,7 @@
->setViewer($this->getRequest()->getUser());
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$branch = $this->getBranch();
diff --git a/src/applications/releeph/controller/product/ReleephProductListController.php b/src/applications/releeph/controller/product/ReleephProductListController.php
--- a/src/applications/releeph/controller/product/ReleephProductListController.php
+++ b/src/applications/releeph/controller/product/ReleephProductListController.php
@@ -21,7 +21,7 @@
return $this->delegateToController($controller);
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/releeph/controller/product/ReleephProductViewController.php b/src/applications/releeph/controller/product/ReleephProductViewController.php
--- a/src/applications/releeph/controller/product/ReleephProductViewController.php
+++ b/src/applications/releeph/controller/product/ReleephProductViewController.php
@@ -148,7 +148,7 @@
return $nav;
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$product = $this->getProduct();
diff --git a/src/applications/settings/controller/PhabricatorSettingsMainController.php b/src/applications/settings/controller/PhabricatorSettingsMainController.php
--- a/src/applications/settings/controller/PhabricatorSettingsMainController.php
+++ b/src/applications/settings/controller/PhabricatorSettingsMainController.php
@@ -151,7 +151,7 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
$panels = $this->buildPanels();
return $this->renderSideNav($panels)->getMenu();
}
diff --git a/src/applications/slowvote/controller/PhabricatorSlowvoteController.php b/src/applications/slowvote/controller/PhabricatorSlowvoteController.php
--- a/src/applications/slowvote/controller/PhabricatorSlowvoteController.php
+++ b/src/applications/slowvote/controller/PhabricatorSlowvoteController.php
@@ -22,11 +22,11 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNavView(true)->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
$crumbs->addAction(
diff --git a/src/applications/tokens/controller/PhabricatorTokenController.php b/src/applications/tokens/controller/PhabricatorTokenController.php
--- a/src/applications/tokens/controller/PhabricatorTokenController.php
+++ b/src/applications/tokens/controller/PhabricatorTokenController.php
@@ -2,7 +2,6 @@
abstract class PhabricatorTokenController extends PhabricatorController {
-
protected function buildSideNav() {
$nav = new AphrontSideNavFilterView();
$nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
@@ -14,11 +13,11 @@
return $nav;
}
- public function buildApplicationMenu() {
+ protected function buildApplicationMenu() {
return $this->buildSideNav()->getMenu();
}
- public function buildApplicationCrumbs() {
+ protected function buildApplicationCrumbs() {
$crumbs = parent::buildApplicationCrumbs();
return $crumbs;
}

File Metadata

Mime Type
text/plain
Expires
Thu, Aug 28, 4:46 PM (5 h, 29 m)
Storage Engine
amazon-s3
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
phabricator/secure/kb/uo/yqu2fpdafpajawty
Default Alt Text
D11241.diff (33 KB)

Event Timeline

Phabricator · Built by Phacility