Page MenuHomePhabricator
Files F18224566

D10637.id25545.diff
No OneTemporary
Actions

D10637.id25545.diff
View Options

diff --git a/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php b/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php
--- a/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php
+++ b/src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php
@@ -9,7 +9,7 @@
public function defineErrorTypes() {
return array(
- 'ERR-INVALID-PARAMETER' => 'Missing or malformed parameter.',
+ 'ERR-INVALID-PARAMETER' => pht('Missing or malformed parameter.'),
);
}
@@ -29,21 +29,22 @@
}
$fields += array(
- 'title' => $is_new ? 'required string' : 'optional string',
- 'description' => 'optional string',
- 'ownerPHID' => 'optional phid',
- 'viewPolicy' => 'optional phid or policy string',
- 'editPolicy' => 'optional phid or policy string',
- 'ccPHIDs' => 'optional list<phid>',
- 'priority' => 'optional int',
- 'projectPHIDs' => 'optional list<phid>',
- 'auxiliary' => 'optional dict',
+ 'title' => $is_new ?
+ pht('required string') : pht('optional string'),
+ 'description' => pht('optional string'),
+ 'ownerPHID' => pht('optional phid'),
+ 'viewPolicy' => pht('optional phid or policy string'),
+ 'editPolicy' => pht('optional phid or policy string'),
+ 'ccPHIDs' => pht('optional list<phid>'),
+ 'priority' => pht('optional int'),
+ 'projectPHIDs' => pht('optional list<phid>'),
+ 'auxiliary' => pht('optional dict'),
);
if (!$is_new) {
$fields += array(
- 'status' => 'optional int',
- 'comments' => 'optional string',
+ 'status' => pht('optional string'),
+ 'comments' => pht('optional string'),
);
}
@@ -84,7 +85,7 @@
$valid_statuses = ManiphestTaskStatus::getTaskStatusMap();
if (!isset($valid_statuses[$status])) {
throw id(new ConduitException('ERR-INVALID-PARAMETER'))
- ->setErrorDescription('Status set to invalid value.');
+ ->setErrorDescription(pht('Status set to invalid value.'));
}
$changes[ManiphestTransaction::TYPE_STATUS] = $status;
}
@@ -95,7 +96,7 @@
$valid_priorities = ManiphestTaskPriority::getTaskPriorityMap();
if (!isset($valid_priorities[$priority])) {
throw id(new ConduitException('ERR-INVALID-PARAMETER'))
- ->setErrorDescription('Priority set to invalid value.');
+ ->setErrorDescription(pht('Priority set to invalid value.'));
}
$changes[ManiphestTransaction::TYPE_PRIORITY] = $priority;
}
@@ -302,7 +303,8 @@
unset($phid_groups[$phid_type]);
if (!empty($phid_groups)) {
throw id(new ConduitException('ERR-INVALID-PARAMETER'))
- ->setErrorDescription('One or more PHIDs were invalid for '.$field.'.');
+ ->setErrorDescription(
+ pht('One or more PHIDs were invalid for %s.', $field));
}
return true;

File Metadata

Mime Type
text/plain
Expires
Thu, Aug 21, 12:10 AM (1 d, 7 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
9048411
Default Alt Text
D10637.id25545.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility