Page MenuHomePhabricator
Files F18184488

D16161.id38877.diff
No OneTemporary
Actions

D16161.id38877.diff
View Options

diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
@@ -198,18 +198,16 @@
$task_submenu[] = id(new PhabricatorActionView())
->setName(pht('Edit Blocking Tasks'))
->setHref("/search/attach/{$phid}/TASK/blocks/")
- ->setWorkflow(true)
->setIcon('fa-link')
->setDisabled(!$can_edit)
- ->setWorkflow(true);
+ ->setWorkflow(!$can_edit);
$task_submenu[] = id(new PhabricatorActionView())
->setName(pht('Merge Duplicates In'))
->setHref("/search/attach/{$phid}/TASK/merge/")
- ->setWorkflow(true)
->setIcon('fa-compress')
->setDisabled(!$can_edit)
- ->setWorkflow(true);
+ ->setWorkflow(!$can_edit);
$curtain->addAction(
id(new PhabricatorActionView())
diff --git a/src/applications/pholio/event/PholioActionMenuEventListener.php b/src/applications/pholio/event/PholioActionMenuEventListener.php
--- a/src/applications/pholio/event/PholioActionMenuEventListener.php
+++ b/src/applications/pholio/event/PholioActionMenuEventListener.php
@@ -42,10 +42,9 @@
return id(new PhabricatorActionView())
->setName(pht('Edit Pholio Mocks'))
->setHref("/search/attach/{$phid}/MOCK/edge/")
- ->setWorkflow(true)
->setIcon('fa-camera-retro')
->setDisabled(!$can_edit)
- ->setWorkflow(true);
+ ->setWorkflow(!$can_edit);
}
}
diff --git a/src/applications/search/controller/PhabricatorSearchAttachController.php b/src/applications/search/controller/PhabricatorSearchAttachController.php
--- a/src/applications/search/controller/PhabricatorSearchAttachController.php
+++ b/src/applications/search/controller/PhabricatorSearchAttachController.php
@@ -18,6 +18,11 @@
$object = id(new PhabricatorObjectQuery())
->setViewer($user)
+ ->requireCapabilities(
+ array(
+ PhabricatorPolicyCapability::CAN_VIEW,
+ PhabricatorPolicyCapability::CAN_EDIT,
+ ))
->withPHIDs(array($phid))
->executeOne();

File Metadata

Mime Type
text/plain
Expires
Aug 17 2025, 1:55 PM (13 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
9472063
Default Alt Text
D16161.id38877.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility