Page MenuHomePhabricator
Files F18106840

D7949.id.diff
No OneTemporary
Actions

D7949.id.diff
View Options

Index: resources/celerity/map.php
===================================================================
--- resources/celerity/map.php
+++ resources/celerity/map.php
@@ -7,7 +7,7 @@
return array(
'names' =>
array(
- 'core.pkg.css' => '52fe21de',
+ 'core.pkg.css' => '6d59624c',
'core.pkg.js' => 'c907bd96',
'darkconsole.pkg.js' => 'ca8671ce',
'differential.pkg.css' => '827749c1',
@@ -23,7 +23,7 @@
'rsrc/css/aphront/context-bar.css' => '1c3b0529',
'rsrc/css/aphront/dark-console.css' => '6378ef3d',
'rsrc/css/aphront/dialog-view.css' => 'dd9db96c',
- 'rsrc/css/aphront/error-view.css' => 'ca515eae',
+ 'rsrc/css/aphront/error-view.css' => '16cd9949',
'rsrc/css/aphront/lightbox-attachment.css' => '686f8885',
'rsrc/css/aphront/list-filter-view.css' => '9f0c29ac',
'rsrc/css/aphront/multi-column.css' => '05bbd016',
@@ -475,7 +475,7 @@
'aphront-contextbar-view-css' => '1c3b0529',
'aphront-dark-console-css' => '6378ef3d',
'aphront-dialog-view-css' => 'dd9db96c',
- 'aphront-error-view-css' => 'ca515eae',
+ 'aphront-error-view-css' => '16cd9949',
'aphront-list-filter-view-css' => '9f0c29ac',
'aphront-multi-column-view-css' => '05bbd016',
'aphront-notes' => '6acadd3f',
Index: src/applications/differential/controller/DifferentialDiffViewController.php
===================================================================
--- src/applications/differential/controller/DifferentialDiffViewController.php
+++ src/applications/differential/controller/DifferentialDiffViewController.php
@@ -20,10 +20,10 @@
return new Aphront404Response();
}
+ $error_view = id(new AphrontErrorView())
+ ->setSeverity(AphrontErrorView::SEVERITY_NOTICE);
if ($diff->getRevisionID()) {
- $top_part = id(new AphrontErrorView())
- ->setSeverity(AphrontErrorView::SEVERITY_NOTICE)
- ->appendChild(
+ $error_view->appendChild(
pht(
'This diff belongs to revision %s.',
phutil_tag(
@@ -85,7 +85,7 @@
id(new AphrontFormSubmitControl())
->setValue(pht('Continue')));
- $top_part = $form;
+ $error_view->appendChild($form);
}
$props = id(new DifferentialDiffProperty())->loadAllWhere(
@@ -148,12 +148,15 @@
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Diff %d', $diff->getID()));
+ $prop_box = id(new PHUIObjectBoxView())
+ ->setHeader($property_head)
+ ->addPropertyList($property_view)
+ ->setErrorView($error_view);
+
return $this->buildApplicationPage(
array(
$crumbs,
- $top_part,
- $property_head,
- $property_view,
+ $prop_box,
$table_of_contents,
$details,
),
Index: webroot/rsrc/css/aphront/error-view.css
===================================================================
--- webroot/rsrc/css/aphront/error-view.css
+++ webroot/rsrc/css/aphront/error-view.css
@@ -23,6 +23,10 @@
margin: 8px;
}
+.aphront-error-view .phui-form-view {
+ padding: 0;
+}
+
.aphront-error-view-body {
padding: 12px;
}

File Metadata

Mime Type
text/plain
Expires
Aug 11 2025, 11:27 PM (10 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8341467
Default Alt Text
D7949.id.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility