Page MenuHomePhabricator
Files F18099045

D17966.id43210.diff
No OneTemporary
Actions

D17966.id43210.diff
View Options

diff --git a/src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php b/src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php
--- a/src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php
+++ b/src/applications/project/xaction/PhabricatorProjectSlugsTransaction.php
@@ -45,21 +45,21 @@
'%s changed project hashtag(s), added %d: %s; removed %d: %s.',
$this->renderAuthor(),
count($add),
- $this->renderSlugList($add),
+ $this->renderValueList($add),
count($rem),
- $this->renderSlugList($rem));
+ $this->renderValueList($rem));
} else if ($add) {
return pht(
'%s added %d project hashtag(s): %s.',
$this->renderAuthor(),
count($add),
- $this->renderSlugList($add));
+ $this->renderValueList($add));
} else if ($rem) {
return pht(
'%s removed %d project hashtag(s): %s.',
$this->renderAuthor(),
count($rem),
- $this->renderSlugList($rem));
+ $this->renderValueList($rem));
}
}
@@ -76,23 +76,23 @@
$this->renderAuthor(),
$this->renderObject(),
count($add),
- $this->renderSlugList($add),
+ $this->renderValueList($add),
count($rem),
- $this->renderSlugList($rem));
+ $this->renderValueList($rem));
} else if ($add) {
return pht(
'%s added %d %s hashtag(s): %s.',
$this->renderAuthor(),
count($add),
$this->renderObject(),
- $this->renderSlugList($add));
+ $this->renderValueList($add));
} else if ($rem) {
return pht(
'%s removed %d %s hashtag(s): %s.',
$this->renderAuthor(),
count($rem),
$this->renderObject(),
- $this->renderSlugList($rem));
+ $this->renderValueList($rem));
}
}
@@ -157,8 +157,4 @@
return $errors;
}
- private function renderSlugList($slugs) {
- return implode(', ', $slugs);
- }
-
}
diff --git a/src/applications/transactions/storage/PhabricatorModularTransactionType.php b/src/applications/transactions/storage/PhabricatorModularTransactionType.php
--- a/src/applications/transactions/storage/PhabricatorModularTransactionType.php
+++ b/src/applications/transactions/storage/PhabricatorModularTransactionType.php
@@ -208,6 +208,19 @@
$value);
}
+ final protected function renderValueList(array $values) {
+ $result = array();
+ foreach ($values as $value) {
+ $result[] = $this->renderValue($value);
+ }
+
+ if ($this->isTextMode()) {
+ return implode(', ', $result);
+ }
+
+ return phutil_implode_html(', ', $result);
+ }
+
final protected function renderOldValue() {
return $this->renderValue($this->getOldValue());
}

File Metadata

Mime Type
text/plain
Expires
Aug 10 2025, 12:57 AM (11 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
9091767
Default Alt Text
D17966.id43210.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility