Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F18095406
D11597.id28637.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
7 KB
Referenced Files
None
Subscribers
None
D11597.id28637.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,10 +7,10 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => 'ba9b6450',
+ 'core.pkg.css' => 'd21889f8',
'core.pkg.js' => '23d653bb',
'darkconsole.pkg.js' => '8ab24e01',
- 'differential.pkg.css' => '380f07e5',
+ 'differential.pkg.css' => '4dd487db',
'differential.pkg.js' => '7b5a4aa4',
'diffusion.pkg.css' => '591664fa',
'diffusion.pkg.js' => 'bfc0737b',
@@ -55,7 +55,7 @@
'rsrc/css/application/dashboard/dashboard.css' => 'c0062064',
'rsrc/css/application/diff/inline-comment-summary.css' => 'eb5f8e8c',
'rsrc/css/application/differential/add-comment.css' => 'c478bcaa',
- 'rsrc/css/application/differential/changeset-view.css' => 'b2b71e76',
+ 'rsrc/css/application/differential/changeset-view.css' => '0fdd60f7',
'rsrc/css/application/differential/core.css' => '7ac3cabc',
'rsrc/css/application/differential/results-table.css' => '181aa9d9',
'rsrc/css/application/differential/revision-comment.css' => '48186045',
@@ -105,7 +105,7 @@
'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
'rsrc/css/application/uiexample/example.css' => '528b19de',
'rsrc/css/core/core.css' => '8f9b9588',
- 'rsrc/css/core/remarkup.css' => 'e8e5a324',
+ 'rsrc/css/core/remarkup.css' => 'b5ef46cb',
'rsrc/css/core/syntax.css' => '56c1ba38',
'rsrc/css/core/z-index.css' => '8239495e',
'rsrc/css/diviner/diviner-shared.css' => '38813222',
@@ -129,7 +129,7 @@
'rsrc/css/phui/phui-document.css' => '8240b0b1',
'rsrc/css/phui/phui-error-view.css' => '41518665',
'rsrc/css/phui/phui-feed-story.css' => 'c9f3a0b5',
- 'rsrc/css/phui/phui-fontkit.css' => '9b345998',
+ 'rsrc/css/phui/phui-fontkit.css' => 'de54c5e7',
'rsrc/css/phui/phui-form-view.css' => '8b78a986',
'rsrc/css/phui/phui-form.css' => '9aecbda1',
'rsrc/css/phui/phui-header-view.css' => '083669db',
@@ -520,7 +520,7 @@
'conpherence-notification-css' => '04a6e10a',
'conpherence-update-css' => '1099a660',
'conpherence-widget-pane-css' => '3d575438',
- 'differential-changeset-view-css' => 'b2b71e76',
+ 'differential-changeset-view-css' => '0fdd60f7',
'differential-core-view-css' => '7ac3cabc',
'differential-inline-comment-editor' => 'f2441746',
'differential-results-table-css' => '181aa9d9',
@@ -738,7 +738,7 @@
'phabricator-phtize' => 'd254d646',
'phabricator-prefab' => '72da38cc',
'phabricator-profile-css' => 'b4896815',
- 'phabricator-remarkup-css' => 'e8e5a324',
+ 'phabricator-remarkup-css' => 'b5ef46cb',
'phabricator-search-results-css' => 'f240504c',
'phabricator-shaped-request' => '7cbe244b',
'phabricator-side-menu-view-css' => '7e8c6341',
@@ -783,7 +783,7 @@
'phui-error-view-css' => '41518665',
'phui-feed-story-css' => 'c9f3a0b5',
'phui-font-icon-base-css' => '3dad2ae3',
- 'phui-fontkit-css' => '9b345998',
+ 'phui-fontkit-css' => 'de54c5e7',
'phui-form-css' => '9aecbda1',
'phui-form-view-css' => '8b78a986',
'phui-header-view-css' => '083669db',
diff --git a/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php b/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php
--- a/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php
+++ b/src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php
@@ -140,7 +140,7 @@
$this->newOption(
'style.monospace',
'string',
- '10px "Menlo", "Consolas", "Monaco", monospace')
+ null)
->setLocked(true)
->setSummary(
pht('Default monospace font.'))
@@ -151,7 +151,7 @@
$this->newOption(
'style.monospace.windows',
'string',
- '11px "Menlo", "Consolas", "Monaco", monospace')
+ null)
->setLocked(true)
->setSummary(
pht('Default monospace font for clients on Windows.'))
diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php
--- a/src/view/page/PhabricatorStandardPageView.php
+++ b/src/view/page/PhabricatorStandardPageView.php
@@ -269,18 +269,31 @@
$response = CelerityAPI::getStaticResourceResponse();
+ $font_css = null;
+ if (!empty($monospaced)) {
+ $font_css = hsprintf(
+ '<style type="text/css">'.
+ '.PhabricatorMonospaced, '.
+ '.phabricator-remarkup .remarkup-code-block '.
+ '.remarkup-code { font: %s !important; } '.
+ '</style>', $monospaced);
+ }
+
+ $font_css_win = null;
+ if (!empty($monospaced_win)) {
+ $font_css_win = hsprintf(
+ '<style type="text/css">'.
+ '.platform-windows .PhabricatorMonospaced, '.
+ '.platform-windows .phabricator-remarkup '.
+ '.remarkup-code-block .remarkup-code { font: %s !important; }'.
+ '</style>', $monospaced_win);
+ }
+
return hsprintf(
- '%s<style type="text/css">'.
- '.PhabricatorMonospaced, '.
- '.phabricator-remarkup .remarkup-code-block '.
- '.remarkup-code { font: %s; } '.
- '.platform-windows .PhabricatorMonospaced, '.
- '.platform-windows .phabricator-remarkup '.
- '.remarkup-code-block .remarkup-code { font: %s; }'.
- '</style>%s',
+ '%s%s%s%s',
parent::getHead(),
- phutil_safe_html($monospaced),
- phutil_safe_html($monospaced_win),
+ $font_css,
+ $font_css_win,
$response->renderSingleResource('javelin-magical-init', 'phabricator'));
}
diff --git a/webroot/rsrc/css/application/differential/changeset-view.css b/webroot/rsrc/css/application/differential/changeset-view.css
--- a/webroot/rsrc/css/application/differential/changeset-view.css
+++ b/webroot/rsrc/css/application/differential/changeset-view.css
@@ -61,7 +61,6 @@
color: {$bluetext};
cursor: pointer;
border-right: 1px solid {$thinblueborder};
- font-size: 11px;
overflow: hidden;
-moz-user-select: -moz-none;
diff --git a/webroot/rsrc/css/core/remarkup.css b/webroot/rsrc/css/core/remarkup.css
--- a/webroot/rsrc/css/core/remarkup.css
+++ b/webroot/rsrc/css/core/remarkup.css
@@ -10,11 +10,19 @@
margin: 0 0 12px;
}
+.PhabricatorMonospaced,
+.phabricator-remarkup .remarkup-code-block .remarkup-code {
+ font: 10px "Menlo", "Consolas", "Monaco", monospace;
+}
+
+.platform-windows .PhabricatorMonospaced,
+.platform-windows .phabricator-remarkup .remarkup-code-block .remarkup-code {
+ font: 11px "Menlo", "Consolas", "Monaco", monospace;
+}
+
.phabricator-remarkup .remarkup-code-block {
margin: 12px 0;
white-space: pre;
- font-family: "Monaco", monospace;
- font-size: 10px;
}
.phabricator-remarkup .remarkup-code-header {
diff --git a/webroot/rsrc/css/phui/phui-fontkit.css b/webroot/rsrc/css/phui/phui-fontkit.css
--- a/webroot/rsrc/css/phui/phui-fontkit.css
+++ b/webroot/rsrc/css/phui/phui-fontkit.css
@@ -17,6 +17,18 @@
line-height: 18px;
}
+.PhabricatorMonospaced .phui-font-source-sans,
+.phui-font-source-sans .phabricator-remarkup .remarkup-code-block
+ .remarkup-code {
+ font-size: 11px;
+}
+
+.platform-windows .PhabricatorMonospaced .phui-font-source-sans,
+.platform-windows .phui-font-source-sans .phabricator-remarkup
+ .remarkup-code-block .remarkup-code {
+ font-size: 12px;
+}
+
.phui-font-source-sans .phabricator-remarkup h2.remarkup-header {
padding: 8px 24px 8px 0;
border-bottom: 1px solid {$thinblueborder};
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Aug 8 2025, 11:27 PM (17 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
9060434
Default Alt Text
D11597.id28637.diff (7 KB)
Attached To
Mode
D11597: Bump monospace font +1px when using Source Sans Pro
Attached
Detach File
Event Timeline
Log In to Comment