Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F18092435
D12957.id31209.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
717 B
Referenced Files
None
Subscribers
None
D12957.id31209.diff
View Options
diff --git a/src/applications/herald/engine/HeraldEngine.php b/src/applications/herald/engine/HeraldEngine.php
--- a/src/applications/herald/engine/HeraldEngine.php
+++ b/src/applications/herald/engine/HeraldEngine.php
@@ -272,6 +272,17 @@
$result = false;
} else {
foreach ($conditions as $condition) {
+
+ try {
+ $object->getHeraldField($condition->getFieldName());
+ } catch (Exception $ex) {
+ $reason = pht(
+ 'Field "%s" does not exist!',
+ $condition->getFieldName());
+ $result = false;
+ break;
+ }
+
$match = $this->doesConditionMatch($rule, $condition, $object);
if (!$all && $match) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Aug 8, 10:24 AM (1 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
9054349
Default Alt Text
D12957.id31209.diff (717 B)
Attached To
Mode
D12957: Make Herald rules more resilient
Attached
Detach File
Event Timeline
Log In to Comment