Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F17986396
D21760.id51872.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
808 B
Referenced Files
None
Subscribers
None
D21760.id51872.diff
View Options
diff --git a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
--- a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
+++ b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
@@ -143,7 +143,14 @@
// Find the smallest "new" changeset ID. We'll consider everything
// larger than this to be "newer", and everything smaller to be "older".
- $first_new_id = min(mpull($new, 'getID'));
+
+ // (It's possible we have no changesets if the commit is empty.)
+
+ if ($new) {
+ $first_new_id = min(mpull($new, 'getID'));
+ } else {
+ $first_new_id = null;
+ }
$results = array();
foreach ($inlines as $inline) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Aug 2, 9:22 PM (2 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8505001
Default Alt Text
D21760.id51872.diff (808 B)
Attached To
Mode
D21760: Fix an issue where we may "min()" an empty array when viewing a revision with no changesets
Attached
Detach File
Event Timeline
Log In to Comment