Page MenuHomePhabricator

D21760.id51872.diff
No OneTemporary

D21760.id51872.diff

diff --git a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
--- a/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
+++ b/src/infrastructure/diff/engine/PhabricatorInlineCommentAdjustmentEngine.php
@@ -143,7 +143,14 @@
// Find the smallest "new" changeset ID. We'll consider everything
// larger than this to be "newer", and everything smaller to be "older".
- $first_new_id = min(mpull($new, 'getID'));
+
+ // (It's possible we have no changesets if the commit is empty.)
+
+ if ($new) {
+ $first_new_id = min(mpull($new, 'getID'));
+ } else {
+ $first_new_id = null;
+ }
$results = array();
foreach ($inlines as $inline) {

File Metadata

Mime Type
text/plain
Expires
Sat, Aug 2, 9:22 PM (2 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8505001
Default Alt Text
D21760.id51872.diff (808 B)

Event Timeline