Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15632921
D16726.id40279.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D16726.id40279.diff
View Options
diff --git a/src/applications/calendar/controller/PhabricatorCalendarImportViewController.php b/src/applications/calendar/controller/PhabricatorCalendarImportViewController.php
--- a/src/applications/calendar/controller/PhabricatorCalendarImportViewController.php
+++ b/src/applications/calendar/controller/PhabricatorCalendarImportViewController.php
@@ -151,6 +151,17 @@
$properties = id(new PHUIPropertyListView())
->setViewer($viewer);
+ $engine = $import->getEngine();
+
+ $properties->addProperty(
+ pht('Source Type'),
+ $engine->getImportEngineTypeName());
+
+ $engine->appendImportProperties(
+ $viewer,
+ $import,
+ $properties);
+
return $properties;
}
diff --git a/src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php b/src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php
--- a/src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php
+++ b/src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php
@@ -9,10 +9,28 @@
return pht('Import .ics File');
}
+ public function getImportEngineTypeName() {
+ return pht('.ics File');
+ }
+
public function getImportEngineHint() {
return pht('Import an event in ".ics" (iCalendar) format.');
}
+
+ public function appendImportProperties(
+ PhabricatorUser $viewer,
+ PhabricatorCalendarImport $import,
+ PHUIPropertyListView $properties) {
+
+ $phid_key = PhabricatorCalendarImportICSFileTransaction::PARAMKEY_FILE;
+ $file_phid = $import->getParameter($phid_key);
+
+ $properties->addProperty(
+ pht('Source File'),
+ $viewer->renderHandle($file_phid));
+ }
+
public function newEditEngineFields(
PhabricatorEditEngine $engine,
PhabricatorCalendarImport $import) {
diff --git a/src/applications/calendar/import/PhabricatorCalendarImportEngine.php b/src/applications/calendar/import/PhabricatorCalendarImportEngine.php
--- a/src/applications/calendar/import/PhabricatorCalendarImportEngine.php
+++ b/src/applications/calendar/import/PhabricatorCalendarImportEngine.php
@@ -9,8 +9,16 @@
abstract public function getImportEngineName();
+ abstract public function getImportEngineTypeName();
abstract public function getImportEngineHint();
+ public function appendImportProperties(
+ PhabricatorUser $viewer,
+ PhabricatorCalendarImport $import,
+ PHUIPropertyListView $properties) {
+ return;
+ }
+
abstract public function newEditEngineFields(
PhabricatorEditEngine $engine,
PhabricatorCalendarImport $import);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, May 20, 8:45 PM (18 h, 59 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8008520
Default Alt Text
D16726.id40279.diff (2 KB)
Attached To
Mode
D16726: Add some descriptive properties when viewing a Calendar import
Attached
Detach File
Event Timeline
Log In to Comment