Page MenuHomePhabricator

D14045.diff
No OneTemporary

D14045.diff

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => '928faf7e',
+ 'core.pkg.css' => '994de4ed',
'core.pkg.js' => '47dc9ebb',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '2de124c9',
@@ -36,7 +36,7 @@
'rsrc/css/application/base/notification-menu.css' => 'f31c0bde',
'rsrc/css/application/base/phabricator-application-launch-view.css' => '95351601',
'rsrc/css/application/base/phui-theme.css' => '6b451f24',
- 'rsrc/css/application/base/standard-page-view.css' => '4d176b67',
+ 'rsrc/css/application/base/standard-page-view.css' => '1f53d056',
'rsrc/css/application/calendar/calendar-icon.css' => 'c69aa59f',
'rsrc/css/application/chatlog/chatlog.css' => 'd295b020',
'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
@@ -141,7 +141,7 @@
'rsrc/css/phui/phui-object-item-list-view.css' => 'ab1bf393',
'rsrc/css/phui/phui-pager.css' => 'bea33d23',
'rsrc/css/phui/phui-pinboard-view.css' => '2495140e',
- 'rsrc/css/phui/phui-property-list-view.css' => '15bbe0b0',
+ 'rsrc/css/phui/phui-property-list-view.css' => '318d4dea',
'rsrc/css/phui/phui-remarkup-preview.css' => '867f85b3',
'rsrc/css/phui/phui-spacing.css' => '042804d6',
'rsrc/css/phui/phui-status.css' => '888cedb8',
@@ -743,7 +743,7 @@
'phabricator-side-menu-view-css' => 'bec2458e',
'phabricator-slowvote-css' => '475b4bd2',
'phabricator-source-code-view-css' => '5e0178de',
- 'phabricator-standard-page-view' => '4d176b67',
+ 'phabricator-standard-page-view' => '1f53d056',
'phabricator-textareautils' => '5c93c52c',
'phabricator-title' => 'df5e11d2',
'phabricator-tooltip' => '1d298e3a',
@@ -794,7 +794,7 @@
'phui-object-item-list-view-css' => 'ab1bf393',
'phui-pager-css' => 'bea33d23',
'phui-pinboard-view-css' => '2495140e',
- 'phui-property-list-view-css' => '15bbe0b0',
+ 'phui-property-list-view-css' => '318d4dea',
'phui-remarkup-preview-css' => '867f85b3',
'phui-spacing-css' => '042804d6',
'phui-status-list-view-css' => '888cedb8',
diff --git a/src/applications/phortune/controller/PhortuneCartViewController.php b/src/applications/phortune/controller/PhortuneCartViewController.php
--- a/src/applications/phortune/controller/PhortuneCartViewController.php
+++ b/src/applications/phortune/controller/PhortuneCartViewController.php
@@ -268,6 +268,7 @@
$refund_uri = $this->getApplicationURI("{$prefix}cart/{$id}/refund/");
$update_uri = $this->getApplicationURI("{$prefix}cart/{$id}/update/");
$accept_uri = $this->getApplicationURI("{$prefix}cart/{$id}/accept/");
+ $print_uri = $this->getApplicationURI("{$prefix}cart/{$id}/?__print__=1");
$view->addAction(
id(new PhabricatorActionView())
@@ -309,6 +310,13 @@
->setHref($resume_uri));
}
+ $view->addAction(
+ id(new PhabricatorActionView())
+ ->setName(pht('Printable Version'))
+ ->setHref($print_uri)
+ ->setOpenInNewWindow(true)
+ ->setIcon('fa-print'));
+
return $view;
}
diff --git a/src/view/layout/PhabricatorActionView.php b/src/view/layout/PhabricatorActionView.php
--- a/src/view/layout/PhabricatorActionView.php
+++ b/src/view/layout/PhabricatorActionView.php
@@ -14,6 +14,7 @@
private $sigils = array();
private $metadata;
private $selected;
+ private $openInNewWindow;
public function setSelected($selected) {
$this->selected = $selected;
@@ -107,6 +108,15 @@
return $this;
}
+ public function setOpenInNewWindow($open_in_new_window) {
+ $this->openInNewWindow = $open_in_new_window;
+ return $this;
+ }
+
+ public function getOpenInNewWindow() {
+ return $this->openInNewWindow;
+ }
+
public function render() {
$icon = null;
@@ -161,11 +171,18 @@
),
$item);
} else {
+ if ($this->getOpenInNewWindow()) {
+ $target = '_blank';
+ } else {
+ $target = null;
+ }
+
$item = javelin_tag(
'a',
array(
'href' => $this->getHref(),
'class' => 'phabricator-action-view-item',
+ 'target' => $target,
'sigil' => $sigils,
'meta' => $this->metadata,
),
diff --git a/webroot/rsrc/css/application/base/standard-page-view.css b/webroot/rsrc/css/application/base/standard-page-view.css
--- a/webroot/rsrc/css/application/base/standard-page-view.css
+++ b/webroot/rsrc/css/application/base/standard-page-view.css
@@ -25,6 +25,10 @@
color: {$greytext};
}
+!print .phabricator-standard-page-footer {
+ display: none;
+}
+
.device-desktop .has-local-nav + .phabricator-standard-page-footer {
margin-left: 221px;
}
diff --git a/webroot/rsrc/css/phui/phui-property-list-view.css b/webroot/rsrc/css/phui/phui-property-list-view.css
--- a/webroot/rsrc/css/phui/phui-property-list-view.css
+++ b/webroot/rsrc/css/phui/phui-property-list-view.css
@@ -176,6 +176,10 @@
border-left: 1px solid {$thinblueborder};
}
+!print .phui-property-list-actions {
+ display: none;
+}
+
.device .phui-property-list-actions {
float: none;
width: auto;

File Metadata

Mime Type
text/plain
Expires
Mon, May 19, 8:14 AM (7 h, 5 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8005097
Default Alt Text
D14045.diff (5 KB)

Event Timeline