Page MenuHomePhabricator
Files F15526345

D10754.diff
No OneTemporary
Actions

D10754.diff
View Options

diff --git a/src/infrastructure/storage/lisk/LiskDAO.php b/src/infrastructure/storage/lisk/LiskDAO.php
--- a/src/infrastructure/storage/lisk/LiskDAO.php
+++ b/src/infrastructure/storage/lisk/LiskDAO.php
@@ -197,6 +197,9 @@
protected $dateCreated;
protected $dateModified;
+ private $dangerousOverrideID;
+ private $dangerousOverrideTimeStamp;
+
/**
* Build an empty object.
*
@@ -210,6 +213,30 @@
}
+/* -( Shooting Yourself in the Foot )------------------------------------- */
+
+ /*
+ * Both of these "dangerous" methods are for overriding when objects
+ * are created/changed and what their IDs are. This is intended for
+ * (A) writing import scripts from other systems (B) setting up test
+ * scenarios.
+ *
+ * They are dangerous and there is little safety to keep you from
+ * wrecking an install. There is no guarantee that future versions
+ * of Phabricator will not place logical constraints on the ordering
+ * of timestamps and bad things may happen if you create impossible scenarios.
+ */
+ public function setDangerousOverrideID($id) {
+ $this->dangerousOverrideID = $id;
+ return $this;
+ }
+
+ public function setDangerousOverrideTimeStamp($ts) {
+ $this->dangerousOverrideTimeStamp = $ts;
+ return $this;
+ }
+
+
/* -( Managing Connections )----------------------------------------------- */
@@ -1155,7 +1182,6 @@
$data = $this->getAllLiskPropertyValues();
$conn = $this->establishConnection('w');
-
$id_mechanism = $this->getConfigOption(self::CONFIG_IDS);
switch ($id_mechanism) {
case self::IDS_AUTOINCREMENT:
@@ -1163,7 +1189,10 @@
// ID column, if it is empty. If the caller has explicitly provided a
// value, use it.
$id_key = $this->getIDKeyForUse();
- if (empty($data[$id_key])) {
+ if (isset($this->dangerousOverrideID)) {
+ $this->setID($this->dangerousOverrideID);
+ $data[$id_key] = $this->dangerousOverrideID;
+ } else if (empty($data[$id_key])) {
unset($data[$id_key]);
}
break;
@@ -1171,7 +1200,10 @@
// If we are using counter IDs, assign a new ID if we don't already have
// one.
$id_key = $this->getIDKeyForUse();
- if (empty($data[$id_key])) {
+ if (isset($this->dangerousOverrideID)) {
+ $this->setID($this->dangerousOverrideID);
+ $data[$id_key] = $this->dangerousOverrideID;
+ } else if (empty($data[$id_key])) {
$counter_name = $this->getTableName();
$id = self::loadNextCounterID($conn, $counter_name);
$this->setID($id);
@@ -1327,10 +1359,15 @@
$use_timestamps = $this->getConfigOption(self::CONFIG_TIMESTAMPS);
if ($use_timestamps) {
- if (!$this->getDateCreated()) {
- $this->setDateCreated(time());
+ if (isset($this->dangerousOverrideTimeStamp)) {
+ $this->setDateCreated($this->dangerousOverrideTimeStamp);
+ $this->setDateModified($this->dangerousOverrideTimeStamp);
+ } else {
+ if (!$this->getDateCreated()) {
+ $this->setDateCreated(time());
+ }
+ $this->setDateModified(time());
}
- $this->setDateModified(time());
}
if ($this->getConfigOption(self::CONFIG_AUX_PHID) && !$this->getPHID()) {

File Metadata

Mime Type
text/plain
Expires
Tue, Apr 22, 8:38 PM (4 d, 14 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7720536
Default Alt Text
D10754.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility