Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15525178
D19725.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
570 B
Referenced Files
None
Subscribers
None
D19725.diff
View Options
diff --git a/src/xsprintf/PhutilTerminalString.php b/src/xsprintf/PhutilTerminalString.php
--- a/src/xsprintf/PhutilTerminalString.php
+++ b/src/xsprintf/PhutilTerminalString.php
@@ -70,6 +70,13 @@
$value = preg_replace('/\r(?!\n)/', '<CR>', $value);
}
+ // See T13209. If we print certain invalid unicode byte sequences to the
+ // terminal under "cmd.exe", the entire string is silently dropped. Avoid
+ // printing invalid sequences.
+ if (phutil_is_windows()) {
+ $value = phutil_utf8ize($value);
+ }
+
return $value;
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Apr 22, 12:41 PM (1 d, 2 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7706500
Default Alt Text
D19725.diff (570 B)
Attached To
Mode
D19725: [Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows
Attached
Detach File
Event Timeline
Log In to Comment