Page MenuHomePhabricator
Files F15508097

D11232.id26973.diff
No OneTemporary
Actions

D11232.id26973.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -285,7 +285,7 @@
'ArcanistHelpWorkflow' => 'ArcanistWorkflow',
'ArcanistHgClientChannel' => 'PhutilProtocolChannel',
'ArcanistHgServerChannel' => 'PhutilProtocolChannel',
- 'ArcanistInfrastructureTestCase' => 'ArcanistTestCase',
+ 'ArcanistInfrastructureTestCase' => 'PhutilLibraryTestCase',
'ArcanistInstallCertificateWorkflow' => 'ArcanistWorkflow',
'ArcanistJSHintLinter' => 'ArcanistExternalLinter',
'ArcanistJSHintLinterTestCase' => 'ArcanistExternalLinterTestCase',
diff --git a/src/__tests__/ArcanistInfrastructureTestCase.php b/src/__tests__/ArcanistInfrastructureTestCase.php
--- a/src/__tests__/ArcanistInfrastructureTestCase.php
+++ b/src/__tests__/ArcanistInfrastructureTestCase.php
@@ -1,37 +1,3 @@
<?php
-final class ArcanistInfrastructureTestCase extends ArcanistTestCase {
-
- /**
- * This is more of an acceptance test case instead of a unit test. It verifies
- * that all symbols can be loaded correctly. It can catch problems like
- * missing methods in descendants of abstract base classes.
- */
- public function testEverythingImplemented() {
- id(new PhutilSymbolLoader())->selectAndLoadSymbols();
- $this->assertTrue(true);
- }
-
- /**
- * This is more of an acceptance test case instead of a unit test. It verifies
- * that all the library map is up-to-date.
- */
- public function testLibraryMap() {
- $library = phutil_get_current_library_name();
- $root = phutil_get_library_root($library);
-
- $new_library_map = id(new PhutilLibraryMapBuilder($root))
- ->buildMap();
-
- $bootloader = PhutilBootloader::getInstance();
- $old_library_map = $bootloader->getLibraryMapWithoutExtensions($library);
- unset($old_library_map[PhutilLibraryMapBuilder::LIBRARY_MAP_VERSION_KEY]);
-
- $this->assertEqual(
- $new_library_map,
- $old_library_map,
- 'The library map does not appear to be up-to-date. Try '.
- 'rebuilding the map with `arc liberate`.');
- }
-
-}
+final class ArcanistInfrastructureTestCase extends PhutilLibraryTestCase {}

File Metadata

Mime Type
text/plain
Expires
Thu, Apr 17, 1:33 AM (6 d, 23 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7737457
Default Alt Text
D11232.id26973.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility