Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15502459
D18599.id44663.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
945 B
Referenced Files
None
Subscribers
None
D18599.id44663.diff
View Options
diff --git a/src/applications/differential/controller/DifferentialRevisionOperationController.php b/src/applications/differential/controller/DifferentialRevisionOperationController.php
--- a/src/applications/differential/controller/DifferentialRevisionOperationController.php
+++ b/src/applications/differential/controller/DifferentialRevisionOperationController.php
@@ -137,9 +137,19 @@
return null;
}
- return $this->newRefQuery($repository)
+ // NOTE: See PHI68. This is a workaround to make "Land Revision" work
+ // until T11823 is fixed properly. If we find multiple refs with the same
+ // name (normally, duplicate "master" refs), just pick the first one.
+
+ $refs = $this->newRefQuery($repository)
->withRefNames(array($default_name))
- ->executeOne();
+ ->execute();
+
+ if ($refs) {
+ return head($refs);
+ }
+
+ return null;
}
private function getDefaultRefName(
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Apr 15, 1:09 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7391340
Default Alt Text
D18599.id44663.diff (945 B)
Attached To
Mode
D18599: Work around workflow blocking error with duplicate "master" refs in "Land Revision"
Attached
Detach File
Event Timeline
Log In to Comment