Page MenuHomePhabricator
Files F15492578

D18529.id44537.diff
No OneTemporary
Actions

D18529.id44537.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@
'names' => array(
'conpherence.pkg.css' => 'e68cf1fa',
'conpherence.pkg.js' => 'b5b51108',
- 'core.pkg.css' => 'b2235af0',
+ 'core.pkg.css' => '03264689',
'core.pkg.js' => '6c085267',
'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '45951e9e',
@@ -177,7 +177,7 @@
'rsrc/css/phui/phui-status.css' => 'd5263e49',
'rsrc/css/phui/phui-tag-view.css' => 'b4719c50',
'rsrc/css/phui/phui-timeline-view.css' => 'f21db7ca',
- 'rsrc/css/phui/phui-two-column-view.css' => '1ade9c5f',
+ 'rsrc/css/phui/phui-two-column-view.css' => 'bf86c483',
'rsrc/css/phui/workboards/phui-workboard-color.css' => '783cdff5',
'rsrc/css/phui/workboards/phui-workboard.css' => '3bc85455',
'rsrc/css/phui/workboards/phui-workcard.css' => 'cca5fa92',
@@ -872,7 +872,7 @@
'phui-tag-view-css' => 'b4719c50',
'phui-theme-css' => '9f261c6b',
'phui-timeline-view-css' => 'f21db7ca',
- 'phui-two-column-view-css' => '1ade9c5f',
+ 'phui-two-column-view-css' => 'bf86c483',
'phui-workboard-color-css' => '783cdff5',
'phui-workboard-view-css' => '3bc85455',
'phui-workcard-view-css' => 'cca5fa92',
diff --git a/src/applications/differential/controller/DifferentialDiffCreateController.php b/src/applications/differential/controller/DifferentialDiffCreateController.php
--- a/src/applications/differential/controller/DifferentialDiffCreateController.php
+++ b/src/applications/differential/controller/DifferentialDiffCreateController.php
@@ -182,10 +182,10 @@
->setValue($button));
$form_box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Diff'))
+ ->setHeaderText($title)
->setValidationException($validation_exception)
->setForm($form)
- ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+ ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setFormErrors($errors);
$crumbs = $this->buildApplicationCrumbs();
@@ -197,15 +197,10 @@
$crumbs->addTextCrumb($title);
$crumbs->setBorder(true);
- $header = id(new PHUIHeaderView())
- ->setHeader($title)
- ->setHeaderIcon($header_icon);
-
$view = id(new PHUITwoColumnView())
- ->setHeader($header)
->setFooter(array(
- $info_view,
$form_box,
+ $info_view,
));
return $this->newPage()
diff --git a/src/view/phui/PHUIInfoView.php b/src/view/phui/PHUIInfoView.php
--- a/src/view/phui/PHUIInfoView.php
+++ b/src/view/phui/PHUIInfoView.php
@@ -59,6 +59,7 @@
} else {
$icon = id(new PHUIIconView())
->setIcon($icon);
+ $this->icon = $icon;
}
return $this;
diff --git a/src/view/phui/PHUITwoColumnView.php b/src/view/phui/PHUITwoColumnView.php
--- a/src/view/phui/PHUITwoColumnView.php
+++ b/src/view/phui/PHUITwoColumnView.php
@@ -106,10 +106,6 @@
$classes[] = 'with-subheader';
}
- if (!$this->header) {
- $classes[] = 'without-header';
- }
-
return array(
'class' => implode(' ', $classes),
);
diff --git a/webroot/rsrc/css/phui/phui-two-column-view.css b/webroot/rsrc/css/phui/phui-two-column-view.css
--- a/webroot/rsrc/css/phui/phui-two-column-view.css
+++ b/webroot/rsrc/css/phui/phui-two-column-view.css
@@ -13,10 +13,6 @@
margin-bottom: 24px;
}
-.phui-two-column-view.without-header {
- margin-top: 24px;
-}
-
.device .phui-two-column-view .phui-two-column-header {
margin-bottom: 12px;
}

File Metadata

Mime Type
text/plain
Expires
Sun, Apr 13, 4:05 PM (2 d, 3 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7741605
Default Alt Text
D18529.id44537.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility