Page MenuHomePhabricator
Files F15486078

D14880.id35970.diff
No OneTemporary
Actions

D14880.id35970.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -8,7 +8,7 @@
return array(
'names' => array(
'core.pkg.css' => 'a419cf4b',
- 'core.pkg.js' => '3c8757c8',
+ 'core.pkg.js' => '2a50ac55',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '2de124c9',
'differential.pkg.js' => '64e69521',
@@ -452,7 +452,7 @@
'rsrc/js/core/DragAndDropFileUpload.js' => 'ad10aeac',
'rsrc/js/core/DraggableList.js' => 'a16ec1c6',
'rsrc/js/core/FileUpload.js' => '477359c8',
- 'rsrc/js/core/Hovercard.js' => 'cb696bed',
+ 'rsrc/js/core/Hovercard.js' => '88e3466d',
'rsrc/js/core/KeyboardShortcut.js' => '1ae869f2',
'rsrc/js/core/KeyboardShortcutManager.js' => 'c1700f6f',
'rsrc/js/core/MultirowRowManager.js' => 'b5d57730',
@@ -747,7 +747,7 @@
'phabricator-file-upload' => '477359c8',
'phabricator-filetree-view-css' => 'fccf9f82',
'phabricator-flag-css' => '5337623f',
- 'phabricator-hovercard' => 'cb696bed',
+ 'phabricator-hovercard' => '88e3466d',
'phabricator-hovercard-view-css' => '1239cd52',
'phabricator-keyboard-shortcut' => '1ae869f2',
'phabricator-keyboard-shortcut-manager' => 'c1700f6f',
@@ -1461,6 +1461,13 @@
'javelin-stratcom',
'javelin-dom',
),
+ '88e3466d' => array(
+ 'javelin-install',
+ 'javelin-dom',
+ 'javelin-vector',
+ 'javelin-request',
+ 'javelin-uri',
+ ),
'88f0c5b3' => array(
'javelin-behavior',
'javelin-dom',
@@ -1812,13 +1819,6 @@
'javelin-stratcom',
'phabricator-phtize',
),
- 'cb696bed' => array(
- 'javelin-install',
- 'javelin-dom',
- 'javelin-vector',
- 'javelin-request',
- 'javelin-uri',
- ),
'ccf1cbf8' => array(
'javelin-install',
'javelin-dom',
diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
@@ -265,7 +265,8 @@
->execute();
foreach ($commit_phids as $phid) {
- $revisions_commits[$phid] = $handles->renderHandle($phid);
+ $revisions_commits[$phid] = $handles->renderHandle($phid)
+ ->setShowHovercard(true);
$revision_phid = key($drev_edges[$phid][$commit_drev]);
$revision_handle = $handles->getHandleIfExists($revision_phid);
if ($revision_handle) {
@@ -273,7 +274,7 @@
unset($edges[$task_drev][$revision_phid]);
$revisions_commits[$phid] = hsprintf(
'%s / %s',
- $revision_handle->renderLink($revision_handle->getName()),
+ $revision_handle->renderHovercardLink($revision_handle->getName()),
$revisions_commits[$phid]);
}
}
diff --git a/webroot/rsrc/js/core/Hovercard.js b/webroot/rsrc/js/core/Hovercard.js
--- a/webroot/rsrc/js/core/Hovercard.js
+++ b/webroot/rsrc/js/core/Hovercard.js
@@ -109,7 +109,7 @@
// If the card is near the top of the window, show it beneath the
// link we're hovering over instead.
- if ((y + margin) < s.y) {
+ if ((y - margin) < s.y) {
y = p.y + d.y + margin;
self._alignment = 'south';
}

File Metadata

Mime Type
text/plain
Expires
Fri, Apr 11, 4:49 AM (1 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7658529
Default Alt Text
D14880.id35970.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility