Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15485510
D19865.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D19865.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -3504,7 +3504,6 @@
'PhabricatorNotificationServersConfigType' => 'applications/notification/config/PhabricatorNotificationServersConfigType.php',
'PhabricatorNotificationStatusView' => 'applications/notification/view/PhabricatorNotificationStatusView.php',
'PhabricatorNotificationTestController' => 'applications/notification/controller/PhabricatorNotificationTestController.php',
- 'PhabricatorNotificationTestFeedStory' => 'applications/notification/feed/PhabricatorNotificationTestFeedStory.php',
'PhabricatorNotificationUIExample' => 'applications/uiexample/examples/PhabricatorNotificationUIExample.php',
'PhabricatorNotificationsApplication' => 'applications/notification/application/PhabricatorNotificationsApplication.php',
'PhabricatorNotificationsSetting' => 'applications/settings/setting/PhabricatorNotificationsSetting.php',
@@ -9323,7 +9322,6 @@
'PhabricatorNotificationServersConfigType' => 'PhabricatorJSONConfigType',
'PhabricatorNotificationStatusView' => 'AphrontTagView',
'PhabricatorNotificationTestController' => 'PhabricatorNotificationController',
- 'PhabricatorNotificationTestFeedStory' => 'PhabricatorFeedStory',
'PhabricatorNotificationUIExample' => 'PhabricatorUIExample',
'PhabricatorNotificationsApplication' => 'PhabricatorApplication',
'PhabricatorNotificationsSetting' => 'PhabricatorInternalSetting',
diff --git a/src/applications/notification/builder/PhabricatorNotificationBuilder.php b/src/applications/notification/builder/PhabricatorNotificationBuilder.php
--- a/src/applications/notification/builder/PhabricatorNotificationBuilder.php
+++ b/src/applications/notification/builder/PhabricatorNotificationBuilder.php
@@ -160,15 +160,6 @@
'href' => $story->getURI(),
'icon' => $story->getImageURI(),
);
- } else if ($story instanceof PhabricatorNotificationTestFeedStory) {
- $dict[] = array(
- 'showAnyNotification' => $web_ready,
- 'showDesktopNotification' => $desktop_ready,
- 'title' => pht('Test Notification'),
- 'body' => $story->renderText(),
- 'href' => null,
- 'icon' => PhabricatorUser::getDefaultProfileImageURI(),
- );
} else {
$dict[] = array(
'showWebNotification' => false,
diff --git a/src/applications/notification/feed/PhabricatorNotificationTestFeedStory.php b/src/applications/notification/feed/PhabricatorNotificationTestFeedStory.php
deleted file mode 100644
--- a/src/applications/notification/feed/PhabricatorNotificationTestFeedStory.php
+++ /dev/null
@@ -1,27 +0,0 @@
-<?php
-
-final class PhabricatorNotificationTestFeedStory extends PhabricatorFeedStory {
-
- public function getPrimaryObjectPHID() {
- return $this->getAuthorPHID();
- }
-
- public function renderView() {
- $data = $this->getStoryData();
-
- $author_phid = $data->getAuthorPHID();
-
- $view = $this->newStoryView();
-
- $view->setTitle($data->getValue('title'));
- $view->setImage($this->getHandle($author_phid)->getImageURI());
-
- return $view;
- }
-
- public function renderText() {
- $data = $this->getStoryData();
- return $data->getValue('title');
- }
-
-}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Apr 11, 12:15 AM (3 d, 15 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7739307
Default Alt Text
D19865.diff (3 KB)
Attached To
Mode
D19865: Remove obsolete "NotifyTest" feed story
Attached
Detach File
Event Timeline
Log In to Comment