Page MenuHomePhabricator
Files F15483635

D20599.id49152.diff
No OneTemporary
Actions

D20599.id49152.diff
View Options

diff --git a/src/applications/harbormaster/engine/HarbormasterBuildGraph.php b/src/applications/harbormaster/engine/HarbormasterBuildGraph.php
--- a/src/applications/harbormaster/engine/HarbormasterBuildGraph.php
+++ b/src/applications/harbormaster/engine/HarbormasterBuildGraph.php
@@ -25,8 +25,7 @@
$graph = id(new HarbormasterBuildGraph($steps_by_phid))
->addNodes($step_phids);
- $raw_results =
- $graph->getBestEffortTopographicallySortedNodes();
+ $raw_results = $graph->getNodesInRoughTopologicalOrder();
$results = array();
foreach ($raw_results as $node) {
diff --git a/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php b/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
--- a/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
+++ b/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
@@ -398,7 +398,7 @@
}
}
- // Now, sort them topographically.
+ // Now, sort them topologically.
$commits = $this->reduceGraph($graph);
$refs = array();
@@ -437,7 +437,7 @@
$graph = new PhutilDirectedScalarGraph();
$graph->addNodes($edges);
- $commits = $graph->getTopographicallySortedNodes();
+ $commits = $graph->getNodesInTopologicalOrder();
// NOTE: We want the most ancestral nodes first, so we need to reverse the
// list we get out of AbstractDirectedGraph.
diff --git a/src/infrastructure/graph/PhabricatorObjectGraph.php b/src/infrastructure/graph/PhabricatorObjectGraph.php
--- a/src/infrastructure/graph/PhabricatorObjectGraph.php
+++ b/src/infrastructure/graph/PhabricatorObjectGraph.php
@@ -189,7 +189,7 @@
$order = id(new PhutilDirectedScalarGraph())
->addNodes($ancestry)
- ->getTopographicallySortedNodes();
+ ->getNodesInTopologicalOrder();
$ancestry = array_select_keys($ancestry, $order);

File Metadata

Mime Type
text/plain
Expires
Thu, Apr 10, 1:35 PM (1 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7225827
Default Alt Text
D20599.id49152.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility