Page MenuHomePhabricator
Files F15477296

D10789.id25888.diff
No OneTemporary
Actions

D10789.id25888.diff
View Options

diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -24,6 +24,7 @@
->needRelationships(true)
->needReviewerStatus(true)
->needReviewerAuthority(true)
+ ->needDrafts(true)
->executeOne();
if (!$revision) {
@@ -258,7 +259,8 @@
$revision,
$field_list,
$warning_handle_map,
- $handles);
+ $handles,
+ $user);
if ($revision_warnings) {
$revision_warnings = id(new AphrontErrorView())
->setSeverity(AphrontErrorView::SEVERITY_WARNING)
@@ -950,7 +952,8 @@
DifferentialRevision $revision,
PhabricatorCustomFieldList $field_list,
array $warning_handle_map,
- array $handles) {
+ array $handles,
+ $user) {
$warnings = array();
foreach ($field_list->getFields() as $key => $field) {
@@ -961,6 +964,9 @@
$warnings[] = $warning;
}
}
+ if ($revision->getDrafts($user)) {
+ $warnings[] = pht('You have unsubmitted comments on this revision.');
+ }
return $warnings;
}
diff --git a/src/applications/differential/view/DifferentialRevisionListView.php b/src/applications/differential/view/DifferentialRevisionListView.php
--- a/src/applications/differential/view/DifferentialRevisionListView.php
+++ b/src/applications/differential/view/DifferentialRevisionListView.php
@@ -127,7 +127,7 @@
if (isset($icons['draft'])) {
$draft = id(new PHUIIconView())
- ->setIconFont('fa-comment-o lightgreytext')
+ ->setIconFont('fa-comment yellow')
->addSigil('has-tooltip')
->setMetadata(
array(

File Metadata

Mime Type
text/plain
Expires
Tue, Apr 8, 1:20 PM (2 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7703837
Default Alt Text
D10789.id25888.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility