Page MenuHomePhabricator
Files F15472498

D9723.id23353.diff
No OneTemporary
Actions

D9723.id23353.diff
View Options

diff --git a/src/lint/linter/ArcanistChmodLinter.php b/src/lint/linter/ArcanistChmodLinter.php
--- a/src/lint/linter/ArcanistChmodLinter.php
+++ b/src/lint/linter/ArcanistChmodLinter.php
@@ -46,6 +46,59 @@
public function lintPath($path) {
if (is_executable($path)) {
if ($this->getEngine()->isBinaryFile($path)) {
+ $mime = Filesystem::getMimeType($path);
+
+ switch ($mime) {
+ // Archives
+ case 'application/jar':
+ case 'application/java-archive':
+ case 'application/x-bzip2':
+ case 'application/x-gzip':
+ case 'application/x-rar-compressed':
+ case 'application/x-tar':
+ case 'application/zip':
+
+ // Audio
+ case 'audio/midi':
+ case 'audio/mpeg':
+ case 'audio/mp4':
+ case 'audio/x-wav':
+
+ // Fonts
+ case 'application/vnd.ms-fontobject':
+ case 'application/x-font-ttf':
+ case 'application/x-woff':
+
+ // Images
+ case 'application/x-shockwave-flash':
+ case 'image/gif':
+ case 'image/jpeg':
+ case 'image/png':
+ case 'image/tiff':
+ case 'image/x-icon':
+ case 'image/x-ms-bmp':
+
+ // Miscellaneous
+ case 'application/msword':
+ case 'application/pdf':
+ case 'application/postscript':
+ case 'application/rtf':
+ case 'application/vnd.ms-excel':
+ case 'application/vnd.ms-powerpoint':
+
+ // Video
+ case 'video/mpeg':
+ case 'video/quicktime':
+ case 'video/x-flv':
+ case 'video/x-msvideo':
+ case 'video/x-ms-wmv':
+
+ $this->raiseLintAtPath(
+ self::LINT_INVALID_EXECUTABLE,
+ pht("'%s' files should not be executable.", $mime));
+ return;
+ }
+
// Path is a binary file, which makes it a valid executable.
return;
} else if ($this->getShebang($path)) {

File Metadata

Mime Type
text/plain
Expires
Sun, Apr 6, 2:00 PM (7 h, 12 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7704050
Default Alt Text
D9723.id23353.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility